![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 13 years ago
Closed 12 years ago
#25913 closed defect (bug) (worksforme)
Investigate why we skip so many Unit Tests
| Reported by: | wonderboymusic | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Unit Tests | Version: | 3.8 |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
My hunch as that we shouldn't be skipping so many tests. I am creating this ticket as a stake to point commits and comments (if necessary).
Change History (11)
#2
follow-up:
↓ 3
@
13 years ago
After running phpunit --verbose: a majority, yes. Also a bunch skip when there is no ImageMagick.
#3
in reply to: ↑ 2
@
13 years ago
Replying to wonderboymusic:
Also a bunch skip when there is no ImageMagick.
Yep, all pretty normal. What would you expect it to do?
We also conditionally include PHP 5.3+ tests, though these are filtered out even earlier so they aren't even included in the skipped test numbers.
#6
in reply to: ↑ 5
@
13 years ago
Replying to wonderboymusic:
The test for #5953 doesn't require the ticket to be closed for its assertions to pass.
There was a consensus some time ago to keep @ticket references even after the ticket is closed (so that we could quickly find the ticket if the test fails in the future):
https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2011-11-02&sort=asc#m327088
https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2012-07-08&sort=asc#m417979
There was a performance issue caused by querying Trac for each ticket separately, but that was fixed in [891/tests].
It's possible to forcibly run skipped tests either by specifying the ticket as a group (phpunit --group 5953), or by uncommenting WP_TESTS_FORCE_KNOWN_BUGS (for all tickets): tags/3.7.1/wp-tests-config-sample.php#L10.
I don't see a reason to remove @ticket references.
#7
@
13 years ago
nacin shared similar sentiments via Skype - that particular unit test doesn't actually call the code it planned on testing, and the ticket remains open due to concerns around realpath()
Nearly all skipped tests are because associated tickets are still open.