WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#25914 closed defect (bug) (fixed)

jshint shouldn't throw errors - wp-includes/js/wplink.js

Reported by: jorbin Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

[L116:C63] W109: Strings must use singlequote.
[L205:C32] W014: Bad line breaking before '+'.
[L206:C32] W014: Bad line breaking before '+'.
[L230:C63] W109: Strings must use singlequote.
[L237:C49] W109: Strings must use singlequote.
[L238:C57] W109: Strings must use singlequote.
[L238:C82] W109: Strings must use singlequote.
[L240:C47] W109: Strings must use singlequote.
[L265:C45] W109: Strings must use singlequote.
[L273:C64] W109: Strings must use singlequote.
[L323:C32] W086: Expected a 'break' statement before 'case'.
[L345:C21] W027: Unreachable 'break' after 'return'.
[L511:C21] W014: Bad line breaking before '+'.
[L512:C21] W014: Bad line breaking before '+'.
[L517:C36] W069: ['title'] is better written in dot notation.
[L519:C89] W069: ['permalink'] is better written in dot notation.
[L521:C33] W069: ['title'] is better written in dot notation.
[L521:C49] W069: ['title'] is better written in dot notation.
[L522:C69] W069: ['info'] is better written in dot notation.
[L581:C22] W109: Strings must use singlequote.
[L62:C19] W117: 'wpActiveEditor' is not defined.
[L65:C35] W117: 'wpActiveEditor' is not defined.
[L70:C28] W117: 'wpLinkL10n' is not defined.
[L82:C20] W117: 'tinyMCEPopup' is not defined.
[L82:C43] W117: 'tinyMCEPopup' is not defined.
[L106:C18] W117: 'tinyMCEPopup' is not defined.
[L108:C13] W117: 'tinyMCEPopup' is not defined.
[L118:C36] W117: 'wpLinkL10n' is not defined.
[L128:C17] W117: 'tinyMCEPopup' is not defined.
[L196:C17] W117: 'selection' is not defined.
[L197:C38] W117: 'selection' is not defined.
[L217:C22] W117: 'tinyMCEPopup' is not defined.
[L221:C13] W117: 'tinyMCEPopup' is not defined.
[L230:C21] W117: 'tinyMCEPopup' is not defined.
[L238:C17] W117: 'tinyMCEPopup' is not defined.
[L240:C17] W117: 'tinymce' is not defined.
[L250:C22] W117: 'tinymce' is not defined.
[L262:C17] W117: 'tinyMCEPopup' is not defined.
[L283:C32] W117: 'wpLinkL10n' is not defined.
[L390:C17] W117: 'setUserSetting' is not defined.
[L511:C23] W117: 'wpLinkL10n' is not defined.
[L521:C61] W117: 'wpLinkL10n' is not defined.
[L576:C21] W117: 'ajaxurl' is not defined.

Attachments (4)

wplink.diff (4.8 KB) - added by jorbin 5 months ago.
wplink.2.diff (4.8 KB) - added by jorbin 5 months ago.
25914.diff (5.0 KB) - added by jorbin 5 months ago.
25914.2.diff (5.6 KB) - added by nacin 5 months ago.

Download all attachments as: .zip

Change History (9)

jorbin5 months ago

jorbin5 months ago

comment:1 jorbin5 months ago

  • Keywords has-patch removed

comment:2 jorbin5 months ago

Patch needs to be updated due to our decision to always have breaks and never have returns in case statements

jorbin5 months ago

comment:3 jorbin5 months ago

  • Keywords has-patch added

nacin5 months ago

comment:4 nacin5 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26193:

Fix JSHint errors in wplink.js.

props jorbin.
fixes #25914.

comment:5 SergeyBiryukov5 months ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.