WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#25923 closed enhancement (fixed)

function no_update_actions() is not used

Reported by: juliobox Owned by: SergeyBiryukov
Milestone: 3.8 Priority: normal
Severity: trivial Version: 2.9
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Hello

in /wp-admin/update-core.php there is a function named no_update_actions() but never used.
Also, if i missed something like "this function is used throught $var ($action = 'no_update'; $callback = $action . '_actions';)" we could now use __return_empty_string().

Thanks you

Attachments (1)

25923.diff (391 bytes) - added by jdgrimes 8 years ago.
Remove the unused function

Download all attachments as: .zip

Change History (9)

@jdgrimes
8 years ago

Remove the unused function

#1 follow-up: @jdgrimes
8 years ago

  • Keywords has-patch added
  • Version changed from trunk to 2.9

This function was introduced in [12097]. It has not been used since [12157].

#2 @juliobox
8 years ago

Thank(without "s" this time) you JD.

Last edited 8 years ago by juliobox (previous) (diff)

#3 @markoheijnen
8 years ago

  • Milestone changed from Awaiting Review to 3.8

#4 @dd32
8 years ago

  • Component changed from Administration to Upgrade/Install
  • Keywords commit added

#5 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26113:

Remove no_update_actions(), unused since [12157]. props jdgrimes. fixes #25923.

#6 @SergeyBiryukov
8 years ago

  • Description modified (diff)

#7 in reply to: ↑ 1 ; follow-up: @juliobox
8 years ago

off topic: how can you find the perfect trac IDs (12157,25923) when this function has been added, used then unused? i would love to do that, perfect. Thank you
Replying to jdgrimes:

This function was introduced in [12097]. It has not been used since [12157].

#8 in reply to: ↑ 7 @SergeyBiryukov
8 years ago

Replying to juliobox:

off topic: how can you find the perfect trac IDs (12157,25923) when this function has been added, used then unused?

Most of the time I just use the Blame feature of Trac (in the upper right corner): trunk/src/wp-admin/update-core.php.

Note: See TracTickets for help on using tickets.