WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25938 closed defect (bug) (fixed)

Twenty Fourteen: "Featured Images" section cut off when front page is static

Reported by: taupecat Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

When switching to a static front page instead of lists of posts, the "featured images" section moves higher on the screen, causing the images in the top row to look cut off compared to its "lists of posts" counterpart, but _only_ when the posts have featured images. o_O

See screenshots at http://imgur.com/ohocd7S

Working on a patch.

Attachments (3)

25938.diff (1.8 KB) - added by taupecat 6 years ago.
Here's the patch. Had to add yet another class onto the body. :-/
25938.1.diff (892 bytes) - added by obenland 6 years ago.
Let's just not add the post class if outside the loop.
25938.2.diff (636 bytes) - added by iamtakashi 6 years ago.

Download all attachments as: .zip

Change History (9)

@taupecat
6 years ago

Here's the patch. Had to add yet another class onto the body. :-/

#1 @taupecat
6 years ago

  • Keywords has-patch added; needs-patch removed

#2 @lancewillett
6 years ago

  • Cc iamtakashi added
  • Milestone changed from Awaiting Review to 3.8

#3 @iamtakashi
6 years ago

@taupecat, thanks for the report.

We just need to limit the treatment to the posts/pages in the main content, site-content. So the appropriate fix would be add site-content to two places. L3202 and 3493 so that the selector become .full-width.singular .site-content .hentry.has-post-thumbnail.

Last edited 6 years ago by iamtakashi (previous) (diff)

@obenland
6 years ago

Let's just not add the post class if outside the loop.

#4 @obenland
6 years ago

  • Keywords commit added

Updated patch. Let's just not add the class in the first place.

@iamtakashi
6 years ago

#5 @iamtakashi
6 years ago

Added a patch to limit the layout treatment to the posts/pages in the main content.

#6 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26150:

Twenty Fourteen: make sure styles for featured content on a static page are limited to posts within the main content area. Props iamtakashi, fixes #25938.

Note: See TracTickets for help on using tickets.