Twenty Fourteen: General code cleanup

[obenland]

Major development is done, now follows the polishing phase.
Lets round up all the bits and pieces that can be shaved off to make Twenty Fourteen in all regards the exemplary theme that it is expected to be.

[obenland]

Remove unused class name.

[obenland]

Simplify and prefix post thumbnail sizes.

[lancewillett]

In 26151:

Twenty Fourteen: remove unused class name, props obenland. See #25946.

[lancewillett]

In 26152:

Twenty Fourteen: simplify and prefix post thumbnail sizes, props obenland. See #25946.

[lancewillett]

In 26154:

Twenty Fourteen: fix tabs to spaces in two files. See #25946.

[iamtakashi]

Remove #main-content where it's not necessary.

[iamtakashi]

Remove a font weight 900 italic which is not necessary in the theme as it is.

[lancewillett]

In 26217:

Twenty Fourteen: remove main-content element where not necessary, props iamtakashi. See #25946.

[lancewillett]

In 26218:

Twenty Fourteen: remove a font weight of 900 italic which isn't needed. Props iamtakashi. See #25946.

[lancewillett]

In 26226:

Twenty Fourteen: fix an issue with keyboard navigation where you couldn't navigate to the previous image. Props obenland, see #25946.

[lancewillett]

In 26227:

Twenty Fourteen: general cleanup for spacing, inline comments. Props obenland, see #25946.

[iamtakashi]

Attached a patch.

• Remove singular body class when a page is set to be the front page.
• Minor style tweaks.

[lancewillett]

In 26249:

Twenty Fourteen: remove singular body class when a page is set to be the front page, and minor style tweaks. Props iamtakashi, see #25946.

[iamtakashi]

Minor style adjustment for navigations and a new lighter pattern-dark graphic which makes easier to change the background color of the featured image content.

[lancewillett]

In 26272:

Twenty Fourteen: minor style adjustments for navigation and a new lighter pattern-dark graphic which makes easier to change the background color of the featured image content. Props iamtakashi.

Also update stylesheet tags. See #25946.

[morganestes]

Fixed theme tags to match the ones allowed (flexible-width, not responsive-width).

[morganestes]

Correct return type from twentyfourteen_font_url().

[morganestes]

Typo correction.

[lancewillett]

In 26325:

Twenty Fourteen: fix typos and a correct @return value, props morganestes. See #25946.

[lancewillett]

In 26326:

Twenty Fourteen: style cite element correctly when not in a blockquote. See #25946.

[seanchayes]

I've added my efforts at consistent code / function calls for the themes js files and added sample header/comment/documentation at the top where it was missing.

Patch 25946.10 added

[lancewillett]

In 26332:

Twenty Fourteen: standardize comment blocks and jQuery function wrapper calls in JavaScript files. Props seanchayes for initial patch, see #25946.

[TobiasBg]

From what I can see, the standardized jQuery function wrapper in [26332] is possibly a change in behavior.

The new form is a self-invoking closure function with the advantage of being able to use $ in the function again.
The old form however is/was a short form of jQuery's ​ready() method (as in jQuery(document).ready(...)) which is used to be sure that the contained code is run once the DOM is ready.

Now, I'm not an expert in jQuery or JS, but I wanted to bring it up so that the JS experts can maybe weigh in. There's some jQuery code in those calls that queries some DOM elements, so I could imagine that waiting for the ready event is a good idea.

[defries]

Removing redundant __(.

[lancewillett]

In 26355:

Twenty Fourteen: remove redundant gettext call, props defries. See #25946.

[kovshenin]

In 25946.10.diff​: filtering false suggests the filter expects a boolean value, but we expect an array. Use an existing function instead.

[kovshenin]

In 25946.11.diff​ prefix the genericons stylesheet handle.

[kovshenin]

In 25946.12.diff​: both style.css and ie.css use Genericons, so let's not forget to declare the dependancy.

[kovshenin]

In 25946.13.diff​: wp_enqueue_scripts does not run in the admin, so twentyfourteen-lato is not registered and thus not enqueued in twentyfourteen_admin_fonts. Patch makes user Lato is enqueued in admin_print_scripts.

[kovshenin]

Sorry for hi-jacking the thread like this. I'm looking at twentyfourteen_paging_nav and there's some pretty interesting stuff there: html_entity_decode, wp_parse_str, WP_Rewrite -- definitely something I wouldn't expect a default theme to do, and also page is the default base, but that can easily be changed, so instead of hard-coding it, we should use $wp_rewrite->pagination_base.

However, given all that magic going on there, I think we should remove it all and write our own simple pagination function for Twenty Fourteen. One that simply uses get_pagenum_link(). Another option would be to play nice and add support for WP-PageNavi, like many themes do. A third option would be to write a patch for a better paginate_links(). Thoughts?

[iamtakashi]

In ​25946.14.diff: Update editor stylesheet to reflect recent changes made in the main stylesheet.

[iamtakashi]

In ​25946.15.diff, Tweak the vertical space for list items in the primary and footer widgets.

[obenland]

Replying to kovshenin:

In 25946.11.diff​ prefix the genericons stylesheet handle.

IIRC, we decided to leave it un-prefixed to avoid duplication in case a third party uses Genericons (like ​Genericon'd or others).

[obenland]

Replying to kovshenin:

A third option would be to write a patch for a better paginate_links().

Yes, this. :) I was actually working on a patch for that during the WCLDN contributor day. But even if we'd move it into core, it would not be compatible with 3.6 and 3.7.

[lancewillett]

In 26560:

Twenty Fourteen: code cleanup, props kovshenin. See #25946.

• Filtering twentyfourteen_has_featured_posts() false suggests the filter expects a boolean value, but we expect an array. Use an existing function instead.
• In both style.css and ie.css use Genericons, so let's not forget to declare the dependancy.
• Make sure Lato font is enqueued in admin_print_scripts.

[lancewillett]

In 26561:

Twenty Fourteen: update editor stylesheet to reflect recent changes made in the main stylesheet. Props iamtakashi, see #25946.

[lancewillett]

In 26562:

Twenty Fourteen: tweak the vertical space for list items in the primary and footer widgets. Props iamtakashi, see #25946.

[lancewillett]

Please open new tickets for new issues.

[lancewillett]

In [26672]:

Twenty Fourteen: remove trailing slashes on void elements such as meta and link, and remove type attribute from script element. See #24499.

[lancewillett]

In 26694:

Twenty Fourteen: remove invalid rel attributes from post thumbnail output, and fix a CSS typo. See #25946 and #25325.

[lancewillett]

In 26699:

Twenty Fourteen: remove unneeded code from image template, see #25946.

[lancewillett]

In 26810:

Twenty Fourteen: minor spacing and CSS formatting fixes. See #25946.