jshint shouldn't throw errors: wp-admin/js/editor.js

[dougwollison]

Pretty much only spacing fixes.

[dougwollison]

initial patch; fixed spacing

[jorbin]

Please remember to include the filename

[dougwollison]

Whoops, forgot while trying to get this submitted from the proper account.

[nacin]

Hi dougwollison, thanks for the patch.

It looks like some query.php documentation snuck into this one. (Also: wow, nice work!)

I tested out the patch and the spacing looks great. But it doesn't look like anything was done to fix JSHint errors. :-)

Here's the ones I found when running it:

Running "jshint:core" (jshint) task
Linting src/wp-admin/js/editor.js ...ERROR
[L197:C109] W109: Strings must use singlequote.
    pee = pee.replace( new RegExp( '<p>\\s*(</?(?:' + blocklist + ')(?: [^>]*)?>)\\s*</p>', 'gi' ), "$1" ); 
Linting src/wp-admin/js/editor.js ...ERROR
[L201:C101] W109: Strings must use singlequote.
    pee = pee.replace( new RegExp( '<p>\\s*(</?(?:' + blocklist + ')(?: [^>]*)?>)', 'gi' ), "$1" ); 
Linting src/wp-admin/js/editor.js ...ERROR
[L202:C102] W109: Strings must use singlequote.
    pee = pee.replace( new RegExp( '(</?(?:' + blocklist + ')(?: [^>]*)?>)\\s*</p>', 'gi' ), "$1" ); 
Linting src/wp-admin/js/editor.js ...ERROR
[L204:C98] W109: Strings must use singlequote.
    pee = pee.replace( new RegExp( '(</?(?:' + blocklist + ')[^>]*>)\\s*<br />', 'gi' ), "$1" ); 
Linting src/wp-admin/js/editor.js ...ERROR
[L16:C28] W117: 'tinyMCE' is not defined.
    var t = this, ed = tinyMCE.get( id ), wrap_id, txtarea_el, dom = tinymce.DOM;
Linting src/wp-admin/js/editor.js ...ERROR
[L16:C74] W117: 'tinymce' is not defined.
    var t = this, ed = tinyMCE.get( id ), wrap_id, txtarea_el, dom = tinymce.DOM;
Linting src/wp-admin/js/editor.js ...ERROR
[L33:C17] W117: 'QTags' is not defined.
        QTags.closeAllTags( id );
Linting src/wp-admin/js/editor.js ...ERROR
[L35:C18] W117: 'tinyMCEPreInit' is not defined.
      if ( tinyMCEPreInit.mceInit[ id ] && tinyMCEPreInit.mceInit[ id ].wpautop )
Linting src/wp-admin/js/editor.js ...ERROR
[L35:C50] W117: 'tinyMCEPreInit' is not defined.
      if ( tinyMCEPreInit.mceInit[ id ] && tinyMCEPreInit.mceInit[ id ].wpautop )
Linting src/wp-admin/js/editor.js ...ERROR
[L41:C26] W117: 'tinymce' is not defined.
        ed = new tinymce.Editor( id, tinyMCEPreInit.mceInit[ id ] );
Linting src/wp-admin/js/editor.js ...ERROR
[L41:C46] W117: 'tinyMCEPreInit' is not defined.
        ed = new tinymce.Editor( id, tinyMCEPreInit.mceInit[ id ] );
Linting src/wp-admin/js/editor.js ...ERROR
[L47:C13] W117: 'setUserSetting' is not defined.
      setUserSetting( 'editor', 'tinymce' );
Linting src/wp-admin/js/editor.js ...ERROR
[L58:C22] W117: 'tinyMCEPreInit' is not defined.
        if ( tinyMCEPreInit.mceInit[ id ] && tinyMCEPreInit.mceInit[ id ].wpautop )
Linting src/wp-admin/js/editor.js ...ERROR
[L58:C54] W117: 'tinyMCEPreInit' is not defined.
        if ( tinyMCEPreInit.mceInit[ id ] && tinyMCEPreInit.mceInit[ id ].wpautop )
Linting src/wp-admin/js/editor.js ...ERROR
[L66:C13] W117: 'setUserSetting' is not defined.
      setUserSetting( 'editor', 'html' );
Linting src/wp-admin/js/editor.js ...ERROR
[L1:C18] W098: 'switchEditors' is defined but never used.
var switchEditors = {

"tinyMCE" should be "tinymce", "tinymce" should be declared as a global (as should tinyMCEPreInit, QTags, setUserSetting, and switchEditors). The others (single quotes) should be pretty simple.

[dougwollison]

Heh, whoops, thought I reset the repo for that.

As for the jsHint errors, mine wasn't throwing any and I didn't see anything about where the rules file was, took a close look and found it.

New patch coming soon.

[dougwollison]

Oh, that's why, I'm using the core repo, not the developer repo.

Was that necessary for the inline hook docs? I swear it was suppose to be core.

[dougwollison]

Attempt #2; fixed spacing, braces, equals, declared globals (not sure if I used the proper method though).

[dougwollison]

Corrected handling of globals. 1 error left; 'switchEditors' is defined but never used

[DrewAPicture]

Replying to dougwollison:

Oh, that's why, I'm using the core repo, not the developer repo.

Was that necessary for the inline hook docs? I swear it was suppose to be core.

There wasn't a problem because core is a packaged version of develop. Going forward if you're generating patches against trunk you should probably use the develop repo.

[dougwollison]

Replying to DrewAPicture:

Replying to dougwollison:

Oh, that's why, I'm using the core repo, not the developer repo.

Was that necessary for the inline hook docs? I swear it was suppose to be core.

There wasn't a problem because core is a packaged version of develop. Going forward if you're generating patches against trunk you should probably use the develop repo.

Understood. I'll keep that in mind and replace my local repo.

[azaozz]

Some more notes:

• Don't think defining the globals for JSHint needs the :false part. This is the ​default.
• The globals should probably be comma separated on the same line, following the same standard as var.
• tinymce is a superset of tinyMCE (tinyMCE exists for back-compat), but tinyMCEPreInit is another global that cannot be changed. Please run some tests with the patched file to confirm all is still working.

[dougwollison]

Revised declaration of globals, restored case of tinyMCE

[dougwollison]

I'm a little confused though, do I need to change the case on tinyMCE at all or in only some places?

Wait, I see what you mean; I hand changed it on tinyMCEPreInit.

I'll put up another diff with the tinymce change.

[dougwollison]

Updated to include proper lowercasing of just tinymce

[azaozz]

In 26224:

JSHint fixes for editor.js. Props dougwollison, fixes #25947

[azaozz]

Replying to dougwollison:

...I hand changed it on tinyMCEPreInit.

Yep, a lot better now :) Thanks.

[dougwollison]

Okay, now to just go through my other 10 patches and fix the global declarations on them.

[azaozz]

No need, whoever commits them can do it.

[dougwollison]

Replying to azaozz:

No need, whoever commits them can do it.

Hehe... too late. One or two patches were corrupted anyway.