WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#25948 closed task (blessed) (fixed)

THX - themes.php updates based on THX38 plugin

Reported by: matveb Owned by: nacin
Milestone: 3.8 Priority: highest omg bbq
Severity: normal Version: 3.8
Component: Customize Keywords:
Focuses: Cc:

Description

Reference: http://make.wordpress.org/core/2013/10/23/thx-presentation/

Tracking merges from plugins.svn.wordpress.org/thx38/ to core here.

Attachments (11)

25948.diff (24.1 KB) - added by nacin 6 years ago.
Lots of cleanup. No more IDs. Exposes problems with overlays + routes matveb is looking into.
25948.2.diff (27.3 KB) - added by matveb 6 years ago.
themes-php-overlap.png (38.7 KB) - added by TobiasBg 6 years ago.
Overlap on themes.php
25948.check_capability.diff (1.2 KB) - added by markoheijnen 6 years ago.
Don't show "Add new theme" block when you don't have the rights
25948.screenshot.diff (568 bytes) - added by markoheijnen 6 years ago.
25948.3.diff (27.7 KB) - added by nacin 6 years ago.
25948.4.diff (27.5 KB) - added by matveb 6 years ago.
25948.5.diff (27.5 KB) - added by matveb 6 years ago.
Fix l18n name
25948.6.diff (731 bytes) - added by kovshenin 6 years ago.
25948.7.diff (728 bytes) - added by kovshenin 6 years ago.
25948.8.diff (382 bytes) - added by kovshenin 6 years ago.

Download all attachments as: .zip

Change History (68)

#1 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26141:

Update the Themes screen, merging THX into core.

  • Name: THX38
  • Description: Update the Themes screen with a new design and experience.
  • Tags: visually-focused, bigger-screenshots, fast, mobile-friendly, backbone-driven
  • Author: matveb, shaunandrews, melchoyce, designsimply, shelob9
  • URI: http://wordpress.org/plugins/thx38/

fixes #25948

#2 @nacin
6 years ago

In 26142:

THX needs this file, for now. see #25948.

#4 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.8
  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @chrisbliss18
6 years ago

I found two issues while working with the Themes page today:

  • The themes are sorted by directory name and not the theme name. This can cause odd issues where some themes seem randomly sprinkled into an otherwise alphabetically-sorted list.
  • The "Broken Themes" information seems to have no specific styling added in order to make it work with the new design. Currently, it is floating up towards the top of the page and has slid underneath the Search box.

I would supply patches for each, but I don't know the preferred way to sort the themes and I don't know if there is an existing design to handle the broken themes listing.

#6 @nacin
6 years ago

In 26215:

Remove debug cruft. props dimadin. see #25948.

#7 @nacin
6 years ago

In 26216:

Sort themes by name on the new themes.php page. see #25948.

@nacin
6 years ago

Lots of cleanup. No more IDs. Exposes problems with overlays + routes matveb is looking into.

@matveb
6 years ago

#8 @matveb
6 years ago

The above simplifies the detailed view rendering when navigating to prev-next themes using routes for all the heavy lifting. Side benefit, there's no more nesting of div.theme-overlay.

#9 @SergeyBiryukov
6 years ago

  • Type changed from enhancement to task (blessed)

#10 @ocean90
6 years ago

25948.2.diff needs a refresh.

@TobiasBg
6 years ago

Overlap on themes.php

#11 @TobiasBg
6 years ago

The .theme-actions bar on the new themes.php overlaps the admin menu.

http://core.trac.wordpress.org/raw-attachment/ticket/25948/themes-php-overlap.png

#12 @dd32
6 years ago

In 26278:

Appearance: Fix a PHP Notice when the update transient isn't available (for example, due to a timeout or being used offline). See #25948

#13 @dd32
6 years ago

In 26280:

Themes page: Remove a z-index which caused the Current Theme overlay to overlay menu's, that otherwise appears unused. See #25948

#14 @dd32
6 years ago

There's a set of Delete Theme action links on the themes page, which are currently display none'd. See .theme .delete-theme generated from tmpl-theme. Doesn't look like they're actually used for anything best I could tell.

@markoheijnen
6 years ago

Don't show "Add new theme" block when you don't have the rights

#15 @markoheijnen
6 years ago

Added a fix for not showing the "Add new theme" in the theme list when you don't have the rights

#16 @ryan
6 years ago

I'm not sufficient for a proper JS review, but looks good to me. Follows the established pattern, checks the right cap, and disallows for multisite.

#17 @SergeyBiryukov
6 years ago

In 26288:

Only show "Add New Theme" block on Manage Themes screen if not Multisite and the user can install themes.

props markoheijnen.
see #25948.

#18 follow-up: @markoheijnen
6 years ago

New patch that checks if an theme has an image. Not sure if a theme block should have a background color like white.

#19 in reply to: ↑ 18 @nacin
6 years ago

Replying to markoheijnen:

New patch that checks if an theme has an image. Not sure if a theme block should have a background color like white.

See #25959

#20 @matveb
6 years ago

Listing related open tickets:

#26003 (current theme visual updates)
#25983 (clear fix for infinite scroll)
#25981 (use _.throttle)
#25967 (highlight color from color scheme)
#25966 (move CSS to wp-admin.css)
#25964 (no-js fallback)
#25963 (updates to Backbone.Router)
#25962 (show detailed view for users without switch capabilities)
#25961 (better overlay sizes)
#25960 (add-new link needs fixing)
#26078 (show update details)

@nacin
6 years ago

@matveb
6 years ago

@matveb
6 years ago

Fix l18n name

#21 @mor10
6 years ago

Filed #26129 to address transparency issue in install theme preview.

Last edited 6 years ago by SergeyBiryukov (previous) (diff)

#22 @dd32
6 years ago

In 26316:

Themes: Move the escaping of content from JS back to PHP. This allows us to take advantage of the display() WP_Theme method to translate the text properly, and to strip out any HTML tags we don't wish to display. Fixes #26100. See #25948

#23 @dd32
6 years ago

In 26320:

Themes: Remove some unused invalid CSS. See #25948

#24 follow-up: @dd32
6 years ago

In 26320:
Themes: Remove some unused invalid CSS. See #25948

Ok, so those vw units were legit & not a typo, sorry about that.. The selector however wasn't, no elements matched, and none of the closest matches to it could actually make use of the rule as far as I could see.

#25 in reply to: ↑ 24 @matveb
6 years ago

Replying to dd32:

Ok, so those vw units were legit & not a typo, sorry about that.. The selector however wasn't, no elements matched, and none of the closest matches to it could actually make use of the rule as far as I could see.

The selector changed during the cleanup and this wasn't updated. I'll take a look and see if we still need some of it.

#26 @dd32
6 years ago

In 26459:

Themes: Remove an unused Delete Theme link on the multiple view. See #25948

#27 @dd32
6 years ago

In 26460:

Themes: Remove a mp6 reference which is no longer needed. See #25948

#28 @dd32
6 years ago

In 26463:

Themes: Remove some unused CSS (we have neither a .theme-categories or .theme-linear-grid). See #25948

#29 @dd32
6 years ago

In 26465:

Themes: Remove a now defunct CSS class, .feature-container, which is no longer in use after r26141. See #25948

#30 @dd32
6 years ago

In 26468:

Themes: Add a clearing <br/> to the end of .theme-browser.
This is needed to cause the browser to render .theme-browser's height as it's true height, previously the reported height was 1*.theme which caused the Theme scroller to kick in immediately (as the threshold was less than 0).
See #25981 See #25948

#31 @dd32
6 years ago

In 26469:

Themes: When the user doesn't have switch_themes capabilities, and we've passed the current theme, detect the theme slug/stylesheet correctly so that the flags are set properly. See #25948

#32 @dd32
6 years ago

In 26470:

Themes: Do extra Cap checks before outputting links, and use full URI's. See #25948

#33 @SergeyBiryukov
6 years ago

[26470] removed "Current Theme" label in line 226, was that intentional?

#34 @dd32
6 years ago

In 26472:

Themes: Restore a label accidentally removed in r26470. Props SergeyBiryukov. See #25948

#35 @dd32
6 years ago

was that intentional?

Nope, hold over from a patch for #26003 - thanks for picking that up.

#36 @helen
6 years ago

Should wp-admin/includes/class-wp-themes-list-table.php be removed, then? MS list table is a separate file/class, as is install.

#37 @dd32
6 years ago

In 26496:

Themes: For small screen sizes, still allow access to the Customize button (Don't hide the theme actions). See #25948

@kovshenin
6 years ago

#38 @kovshenin
6 years ago

@dd32 in [26470] you removed customizeURI from wp.themes.data.settings but it's still in use in wp-admin/themes.php so the Customize link is now broken. See 25948.6.diff.

@kovshenin
6 years ago

#40 @samuelsidler
6 years ago

  • Priority changed from normal to highest omg bbq

#41 @kovshenin
6 years ago

Can anyone explain how themes.data.settings.extraRoutes is supposed to work? It doesn't look like _.extend() on themes.routes in theme.js is working as expected so there's really nothing we can do with those extra routes, unless I'm missing something.

To add the ability to browse themes from subfolders, I had to extend wp.themes.routes manually, which feels rather hacky.

#42 @SergeyBiryukov
6 years ago

In 26508:

Fix Customize link in theme info window. props kovshenin. see #25948.

#43 @dd32
6 years ago

To add the ability to browse themes from subfolders

Core supports themes 2 levels deep (/wp-content/themes/prefix/theme-name/style.css) so we need to support that in core.

#44 @dd32
6 years ago

In 26513:

Themes: Fix the routing for Themes in a sub-directory (/wp-content/themes/prefix/theme-name/style.css) and navigate to hash-url's for searches. See #25948

#45 @dd32
6 years ago

In 26514:

Themes: We no longer have a delete link on the multi-grid view. See #25948

#46 @dd32
6 years ago

In 26515:

Themes: For searches, replace the document hash, don't add a new history event for each keypress. See #25948

#47 @dd32
6 years ago

In 26522:

Themes: Remove some HTML from a new string and put it in the replacement value instead. See #25948

#48 @dd32
6 years ago

In 26523:

Themes: Standardise on dot notation for object access in the Templates. See #25948

#49 @dd32
6 years ago

In 26524:

Themes: Update notifiations shouldn't be a <a> if they're not links, data.update already contains <p> tags. See #25948

@kovshenin
6 years ago

#50 follow-up: @kovshenin
6 years ago

In 25948.8.diff: add a filter to wp_prepare_themes_for_js similar to how we filter wp_prepare_attachment_for_js.

#51 in reply to: ↑ 50 ; follow-up: @nacin
6 years ago

Replying to kovshenin:

In 25948.8.diff: add a filter to wp_prepare_themes_for_js similar to how we filter wp_prepare_attachment_for_js.

Use case?

#52 @nacin
6 years ago

In 26529:

Themes: Always include the current theme in the list, even if it is not allowed.

see #25948.

#53 in reply to: ↑ 51 @kovshenin
6 years ago

Replying to nacin:

Use case?

Additional data in themes: they could be premium, they could have a price, they could be purchased or not purchased yet, they could have a purchase link, a demo link, fields for extra sorting, like by alpha, by date, etc.

#54 @nacin
6 years ago

In 26531:

For the current theme, display all available actions, as dictated by the admin menu.

Restores 3.7 behavior. This could include things like Header and Background as well as theme options pages.

see #25948.

#55 @dd32
6 years ago

In 26551:

Themes: Update the CSS definitions in the SCSS files to be as specific as the base CSS rules. See #25948, #25966

#56 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26625:

Add wp_prepare_themes_for_js filter to wp_prepare_themes_for_js().

props kovshenin.
fixes #25948.

#57 @nacin
6 years ago

In 26728:

Remove screenshotGallery. see #25948.

Note: See TracTickets for help on using tickets.