Make WordPress Core

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#25949 closed defect (bug) (fixed)

THX38 does not check theme support for current theme

Reported by: mikehansenme's profile MikeHansenMe Owned by: ocean90's profile ocean90
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

I have been working on a theme that happens to not have a widget area. I went to look into what the widget screen would look like and was happy that the menu for widgets did not show at all. When using the new theme screen I clicked the current theme and noticed 3 buttons near the bottom(Customize, Menu, and Widgets). We need to check current theme support before showing buttons.

Attachments (3)

thx38.theme-support.diff (934 bytes) - added by MikeHansenMe 12 years ago.
check for theme support
thx38.theme-support.2.diff (935 bytes) - added by MikeHansenMe 12 years ago.
missing space :)
25949.3.patch (1.1 KB) - added by dimadin 11 years ago.

Download all attachments as: .zip

Change History (8)

@MikeHansenMe
12 years ago

check for theme support

@MikeHansenMe
12 years ago

missing space :)

#1 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.8

#2 @ocean90
11 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 26335:

Appearance Themes: Don't show theme actions if the current theme doesn't support menus or widgets.

props MikeHansenMe.
fixes #25949.

@dimadin
11 years ago

#3 @dimadin
11 years ago

There is a space missing after if, and I believe that according to new coding standards if PHP and HTML are mixed we should use colon and endif instead of braces.

#4 @bpetty
11 years ago

In general, endif-style conditionals are still allowed when breaking into HTML, however, the coding standards don't require it.

#5 @lancewillett
11 years ago

  • Component changed from Themes to Appearance
Note: See TracTickets for help on using tickets.