WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#2595 closed defect (bug) (fixed)

Option of "action" with value "update" is being added to options table

Reported by: markjaquith Owned by: markjaquith
Milestone: 2.1 Priority: low
Severity: trivial Version: 2.1
Component: Administration Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

the hidden form field on wp-admin/options.php with name "action" and value "update" is causing an option of that name and value to be added to the options table. Oops!

Attachments (2)

kill_action_option.diff (355 bytes) - added by markjaquith 9 years ago.
Kill the "action" option
these_are_not_options.diff (626 bytes) - added by markjaquith 9 years ago.

Download all attachments as: .zip

Change History (7)

@markjaquith9 years ago

Kill the "action" option

comment:1 @markjaquith9 years ago

  • Keywords has-patch 2nd-opinion added
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

Fix unsets $_POST$wpvar?; in the "WP vars to set" loop. Anything that we're running through this loop (only "action") we don't want showing up as an option.

People who already have it added are stuck with it, but it'd be silly to write code to remove it... it does no harm.

comment:2 @markjaquith9 years ago

New patch adds 'Update' to the list of things to reset, as the submit button was being added to the Options table as well.

comment:3 @markjaquith8 years ago

Related (duplicate?): #3185

comment:4 @markjaquith8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4332]) Prevent non-option form elements from sneaking in to the options table. fixes #2595

comment:5 @markjaquith8 years ago

(In [4333]) Prevent non-option form elements from sneaking in to the options table. fixes #2595

Note: See TracTickets for help on using tickets.