WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#25955 closed defect (bug) (fixed)

jshint shouldn't throw errors: wp-admin/js/revisions.js

Reported by: adamsilverstein's profile adamsilverstein Owned by: nacin's profile nacin
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

wp-admin/js/revisions.js is still throwing some errors, not sure how they crept back in - I will fix them!

Linting src/wp-admin/js/revisions.js ...ERROR
[L958:C4] W099: Mixed spaces and tabs.
            leftDragBoundary  = view.$el.offset().left,
Linting src/wp-admin/js/revisions.js ...ERROR
[L959:C4] W099: Mixed spaces and tabs.
            sliderOffset      = leftDragBoundary,
Linting src/wp-admin/js/revisions.js ...ERROR
[L960:C4] W099: Mixed spaces and tabs.
            sliderRightEdge   = leftDragBoundary + view.$el.width(),
Linting src/wp-admin/js/revisions.js ...ERROR
[L961:C4] W099: Mixed spaces and tabs.
            rightDragBoundary = sliderRightEdge,
Linting src/wp-admin/js/revisions.js ...ERROR
[L962:C4] W099: Mixed spaces and tabs.
            leftDragReset     = '0',
Linting src/wp-admin/js/revisions.js ...ERROR
[L963:C4] W099: Mixed spaces and tabs.
            rightDragReset    = '100%',
Linting src/wp-admin/js/revisions.js ...ERROR
[L964:C4] W099: Mixed spaces and tabs.
            handles,
Linting src/wp-admin/js/revisions.js ...ERROR
[L965:C4] W099: Mixed spaces and tabs.
            handle            = $( ui.handle );

Attachments (2)

25955.diff​ (1.3 KB) - added by adamsilverstein 11 years ago.
swap spaces for tabs
25955.2.diff​ (1.4 KB) - added by adamsilverstein 11 years ago.
add missing space in global line

Download all attachments as: .zip

Change History (7)

#1 @adamsilverstein
11 years ago

  • Summary changed from jshint shouldn't throw errors: to jshint shouldn't throw errors: wp-admin/js/revisions.js i

#2 @adamsilverstein
11 years ago

  • Keywords has-patch added; needs-patch removed
  • Summary changed from jshint shouldn't throw errors: wp-admin/js/revisions.js i to jshint shouldn't throw errors: wp-admin/js/revisions.js

25955.diff​ swaps spaces for tabs, clears file of all jshint errors

@adamsilverstein
11 years ago

swap spaces for tabs

@adamsilverstein
11 years ago

add missing space in global line

#3 @nacin
11 years ago

  • Milestone changed from Awaiting Review to 3.8

They snuck back in after we removed smarttabs: true.

#4 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26162:

Fix JSHint errors (again) for revisions.js.

props adamsilverstein.
fixes #25955.

#5 @atimmer
11 years ago

#26007 was marked as a duplicate.

Note: See TracTickets for help on using tickets.