WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#25961 closed enhancement (fixed)

Appearance Themes: theme detailed view can use more of the viewport's height in some cases

Reported by: matveb Owned by: dd32
Priority: normal Milestone: 3.8
Component: Customize Version: 3.8
Severity: normal Keywords: has-patch
Cc: Focuses: ui

Description

The overlay used to show theme details should have more flexible top and bottom margins. Specially when the window height is small, a lot of space is wasted.

Attachments (1)

25961.diff​ (728 bytes ) - added by shaunandrews 13 years ago.
Replacing the fixed px spacing for the modal with percentages.

Download all attachments as: .zip

Change History (5)

@shaunandrews
13 years ago

Replacing the fixed px spacing for the modal with percentages.

#1 @SergeyBiryukov
13 years ago

  • Keywords ui-focus has-patch added
  • Milestone Awaiting Review → 3.8

#2 @shaunandrews
13 years ago

I've rolled this patch into #26192 as that ticket affects the positioning of the modal as well.

#3 @dd32
13 years ago

  • Owner set to dd32
  • Resolution → fixed
  • Status new → closed

In 26519:

Themes: Make the Theme Detail view div use more of the available viewport, Fix the Header and Footer in the viewport and only scroll the theme details, Prefix some more theme CSS classes. Props shaunandrews for the initial viewport patch. Fixes #25961, #26192

#4 @dd32
13 years ago

In 26520:

Themes: Indent the HTML for proper indentation after r26519 added an extra div. See #25961, #26192

Note: See TracTickets for help on using tickets.