WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25962 closed enhancement (fixed)

Appearance Themes: if a user has no switch_themes privileges, show the detailed view of the current theme

Reported by: matveb Owned by: nacin
Milestone: 3.8 Priority: low
Severity: normal Version: 3.8
Component: Customize Keywords: has-patch commit
Focuses: Cc:

Description

Instead of showing a mostly empty screen, take advantage of the detailed view each theme has and render that instead.

Attachments (4)

25962.diff (2.7 KB) - added by matveb 6 years ago.
25962.1.diff (1.9 KB) - added by matveb 6 years ago.
25962.2.diff (1.9 KB) - added by matveb 6 years ago.
25962.3.diff (1.2 KB) - added by matveb 6 years ago.
Disables collapse actions when in single-theme mode, improve the responsive layout

Download all attachments as: .zip

Change History (11)

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.8

#2 @samuelsidler
6 years ago

  • Priority changed from normal to low

@matveb
6 years ago

#3 @matveb
6 years ago

  • Keywords has-patch added

@matveb
6 years ago

@matveb
6 years ago

#4 @markjaquith
6 years ago

  • Keywords commit added

25962.2.diff works well for me, and gets my vote for commit.

#5 @nacin
6 years ago

In 26652:

Themes: When only one theme is available, show just the details view.

Only one theme may be available when no other themes are allowed (multisite), no other themes are installed, or when the user is denied the switch_themes capability but still has edit_theme_options.

props matveb, markjaquith.
see #25962.

#6 @nacin
6 years ago

Two things left after this commit:

  • Pressing the escape key causes the details view to vanish. Wonder what else is possible here. Arrow keys don't seem to do anything, so that's good.
  • matveb was going to tweak the responsive breakpoints, I think.

@matveb
6 years ago

Disables collapse actions when in single-theme mode, improve the responsive layout

#7 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26660:

Themes: Disable collapse actions when showing only a single theme; improve the responsive layout.

props matveb.
fixes #25962.

Note: See TracTickets for help on using tickets.