WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#25967 closed defect (bug) (fixed)

Appearance Themes: current theme highlight color should match the color scheme

Reported by: matveb's profile matveb Owned by: iammattthomas's profile iammattthomas
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

The current theme highlight is currently set to blue, but it should be set by the mp6 color scheme instead.

Attachments (1)

25967.diff​ (430 bytes) - added by ryelle 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
11 years ago

  • Keywords ui-focus added
  • Milestone changed from Awaiting Review to 3.8

@ryelle
11 years ago

#2 @ryelle
11 years ago

25967.diff​ adds the theme-name to the _admin.scss file, which is used to generate the color schemes. It uses the $base-color as background & $text-color as text color (this matches the admin menu in all core schemes).

#3 @melchoyce
11 years ago

  • Keywords has-patch added

#4 @ocean90
11 years ago

.theme-browser .add-new-theme:hover:after and .theme-browser .add-new-theme:hover span:after are needed too.
Shouldn't it be $highlight-color?

Last edited 11 years ago by ocean90 (previous) (diff)

#5 @iammattthomas
11 years ago

  • Owner set to iammattthomas
  • Resolution set to fixed
  • Status changed from new to closed

In 26422:

Match current theme background and add theme hover state color to the highlight color in color schemes. Fixes #25967, props ryelle.

#6 @iammattthomas
11 years ago

r26422 is ryelle's patch + the add-new-theme hover state. Only other color in themes is the orange used when an update is available; I'm not sure if that color is used anywhere else in core, but I think it's a separate issue.

Last edited 11 years ago by iammattthomas (previous) (diff)
Note: See TracTickets for help on using tickets.