Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#25968 closed enhancement (fixed)

MP6: buttons.css is incorrectly overriding wp-admin.css

Reported by: johnbillion's profile johnbillion Owned by: iammattthomas's profile iammattthomas
Milestone: 3.8 Priority: high
Severity: normal Version: 3.8
Component: Administration Keywords: needs-ui has-patch dev-feedback
Focuses: ui Cc:

Description

MP6 in plugin form enqueues its stylesheets after core's buttons.css. MP6's styles have now been merged into wp-admin.css which is loaded before buttons.css. This means some responsive button styles in wp-admin.css are not being applied as they should be.

Example: the "Apply" button at the bottom of post listing screens does not get its extra padding applied on the <782px media query.

Also the "Default" button in the Iris color picker does not get any extra padding in this media query because there's no extra padding given to .button-small.

Attachments (1)

25968.diff (2.4 KB) - added by melchoyce 11 years ago.

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
11 years ago

  • Component changed from Graphic Design to Administration
  • Keywords ui-focus added
  • Milestone changed from Awaiting Review to 3.8

#2 @iammattthomas
11 years ago

MP6 responsive button styles need to be moved from wp-admin.css to buttons.css.

#3 @iammattthomas
11 years ago

  • Cc mt@… added

@melchoyce
11 years ago

#4 @melchoyce
11 years ago

  • Keywords has-patch dev-feedback added

Took a first stab at migrating button styles over from wp-admin.css to buttons.css. Currently, this only moves over styles that include ".button". I'd appreciate another set of eyes to make sure I migrated the right styles and didn't miss anything that should have been moved over.

#5 @melchoyce
11 years ago

Also — my patch doesn't tackle this:

Also the "Default" button in the Iris color picker does not get any extra padding in this media query because there's no extra padding given to .button-small.

#6 @matt
11 years ago

  • Priority changed from normal to high

#7 @iammattthomas
11 years ago

  • Owner set to iammattthomas
  • Resolution set to fixed
  • Status changed from new to closed

In 26386:

Move responsive button styles from wp-admin.css to buttons.css. Fixes #25968, props melchoyce.

Note: See TracTickets for help on using tickets.