WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#2598 closed defect (bug) (fixed)

TinyMCE 2.0.5

Reported by: skeltoac Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0.2
Component: Administration Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

Fixes many bugs, moves editor code into single function, adds spellcheck.

Patch consists of a small diff and a big tarball. Remove ALL of wp-includes/js/tinymce before untarring. This tarball has everything that is needed.

If Pspell is not installed, spellcheck will try to contact Google.

Any and all error reports on this may be sent to (my username here) at gmail.com. (Because if you just post a bug here and I can't replicate it, I'll need to contact you but I probably don't have your email address. Please post here AND email me. Thanks.)

Attachments (4)

mce205sc.diff (9.7 KB) - added by skeltoac 8 years ago.
tinymce.tar.gz (157.1 KB) - added by skeltoac 8 years ago.
tinymce.zip (210.9 KB) - added by davidhouse 8 years ago.
For Firas
2598.patch (1.2 KB) - added by apidevlab 8 years ago.

Download all attachments as: .zip

Change History (12)

skeltoac8 years ago

skeltoac8 years ago

comment:1 markjaquith8 years ago

Works very well on FF 1.5.0.1 / OS X. It responded very quickly, so I'm guessing it was using Pspell, which I do have installed on my server.

The only quirk I encountered was that it would suggest words that it would later decide were invalid! For instance, I wrote "blowfishh" and it suggested "blowfish" ... but after correction, on the next press of the spellcheck button, it said that "blowfish" was no good, and recommended "blow-fish" ??? No idea what's going on there, but it would be nice if the recommended words were actually acceptable spellings themselves!

(in case you don't have it: mark.wordpress - at - txfx - dot - net)

davidhouse8 years ago

For Firas

comment:2 skeltoac8 years ago

markjaquith: My pspell doesn't recognize "blowfish" either, but when I changed it to "blow-fish" it was okay.

Modifying config.php, I forced it to use the Google API and it did exactly what you described, so I would guess that your aspell binary is not where the plugin is looking. Check config.php.

comment:3 firas8 years ago

The 'No Misspellings Found' dialog needs to go, that should be communicated modelessly.

comment:4 ryan8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3664]) tinyMCE 2.0.5 coming at you live. fixes #2598

comment:5 apidevlab8 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

apidevlab8 years ago

comment:6 JackD8 years ago

I tried installing the files in tinymce.tar.gz and making the changes noted in mce205sc.diff to my local windows based version of WP but the rich text editor does not show up. I like to work on a local copy and get it working before installing it on my server. Are there any other requirements or changes, besides those noted, to get TinyMCE 2.0.5 working in WP 2.0.2?

comment:7 JackD8 years ago

The following fixed my previous problem.
http://trac.wordpress.org/ticket/2658

The archives (tinymce.tar.gz) given in this ticket are stale and need to be updated.

comment:8 skeltoac8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

They won't be updated. They were uploaded as a way to get the patch into trac. Now that it's in, it's history. Sorry.

Note: See TracTickets for help on using tickets.