WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#25986 closed defect (bug) (fixed)

jshint shouldn't throw errors: wp-includes/js/heartbeat.js

Reported by: dziudek's profile dziudek Owned by: nacin's profile nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

6 JSLint errors to fix

2 JSLint errors are connected with checking type of global variables: pagenow and ajaxurl.

Attachments (1)

25986.diff​ (1.6 KB) - added by dziudek 11 years ago.

Download all attachments as: .zip

Change History (5)

@dziudek
11 years ago

#1 @dziudek
11 years ago

  • Keywords has-patch added

The attached patch file fixes the following JSLint problems:

  • missing radix parameter in the parseInt function
  • 3 times unused "e" variable in the callback for the events
  • unachievable break statement after the return
  • mixed tabs and spaces in one place
Last edited 11 years ago by dziudek (previous) (diff)

#2 @nacin
11 years ago

Sorry dziudek, this file just got largely re-written in [26169]. Luckily there was not much work for you here. :-)

#3 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26197:

Fix JSHint errors in heartbeat.js.

props dziudek.
fixes #25986.

#4 @nacin
11 years ago

  • Milestone changed from Awaiting Review to 3.8

Moving fixed JSHint error tickets to 3.8.

Note: See TracTickets for help on using tickets.