WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25998 closed defect (bug) (fixed)

Hook Docs (7): wp-admin/includes/update-core.php

Reported by: JoshuaAbenazer Owned by: kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch commit
Focuses: docs Cc:
PR Number:

Description

Attached patch has docs for the update_feedback filters and _core_updated_successfully action in wp-admin/includes/update-core.php

Attachments (4)

wp-admin_includes_update-core-php.diff (3.8 KB) - added by JoshuaAbenazer 6 years ago.
25998.diff (3.5 KB) - added by kpdesign 6 years ago.
Second pass
25998.2.diff (4.2 KB) - added by DrewAPicture 6 years ago.
3rd pass
25998.3.diff (4.2 KB) - added by kpdesign 6 years ago.
Fourth pass

Download all attachments as: .zip

Change History (11)

#1 @kpdesign
6 years ago

  • Owner set to kpdesign
  • Status changed from new to reviewing

#2 @DrewAPicture
6 years ago

  • Keywords needs-patch added; has-patch removed
  • Summary changed from Hook Docs: wp-admin/includes/update-core.php to Hook Docs (7): wp-admin/includes/update-core.php

wp-admin_includes_update-core-php.diff looks like a good start. The update_feedback could definitely benefit from a long description explaining the various contexts the filter is evaluated under. Also make sure not remove the newline at the end of the file.

@kpdesign
6 years ago

Second pass

#3 @kpdesign
6 years ago

  • Keywords has-patch docs-feedback added; needs-patch removed

25998.diff includes some formatting changes, and incorporates the changes from comment:2.

@DrewAPicture
6 years ago

3rd pass

#4 @DrewAPicture
6 years ago

  • Keywords docs-feedback removed
  • Milestone changed from Awaiting Review to 3.9

25998.2.diff should cover it. Did a tiny bit of formatting and added duplicate tags for the update_feedback filter calls in wp-admin/includes/class-wp-upgrader.php.

Needs a secondary review and recommendation.

#5 @jeremyfelt
6 years ago

  • Component changed from Inline Docs to Upgrade/Install
  • Focuses docs added

@kpdesign
6 years ago

Fourth pass

#6 @kpdesign
6 years ago

  • Keywords commit added

25998.3.diff contains one minor formatting change.

This one's ready to go in. Recommend commit.

#7 @DrewAPicture
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27047:

Inline documentation for hooks in wp-admin/includes/update-core.php.

Props JoshuaAbenazer, kpdesign.
Fixes #25998.

Note: See TracTickets for help on using tickets.