WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#26000 closed defect (bug) (fixed)

jshint shouldn't throw errors: wp-admin/js/image-edit.js

Reported by: dougwollison Owned by: SergeyBiryukov
Milestone: 3.8 Priority: high
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

Patch to come

Attachments (5)

26000.diff (30.6 KB) - added by dougwollison 5 months ago.
Initial changes: spacing, braces, equals, key fixes, globals. Note: typof callback !== 'undefined' or 'unknown'?
26000.2.diff (30.5 KB) - added by dougwollison 5 months ago.
Revised declaration of globals.
26000.3.diff (11.0 KB) - added by dougwollison 5 months ago.
Just the jshint fixes.
26000.4.diff (11.0 KB) - added by jorbin 5 months ago.
refresh from root
26000.patch (628 bytes) - added by markoheijnen 5 months ago.

Download all attachments as: .zip

Change History (12)

dougwollison5 months ago

Initial changes: spacing, braces, equals, key fixes, globals. Note: typof callback !== 'undefined' or 'unknown'?

comment:1 dougwollison5 months ago

  • Keywords has-patch added

dougwollison5 months ago

Revised declaration of globals.

dougwollison5 months ago

Just the jshint fixes.

comment:2 jorbin5 months ago

  • Milestone changed from Awaiting Review to 3.8

jorbin5 months ago

refresh from root

comment:3 jorbin5 months ago

  • Keywords commit added

Many of the eqeqeq here are necessary and since those are potentially breaking changes, I tested this patch and everything looks good. What I tested:

  • Cropping via selecting
  • Changing crop size via input boxes
  • Rotating left
  • Rotating RIght
  • Flipping vertical
  • Flipping horizontal
  • Going "back" for all of these
  • going "forward" with all of these
  • Saving
  • Restoring original

comment:4 SergeyBiryukov5 months ago

26000.4.diff has a typo in line 33 (coming from the first patch). Will fix on commit.

comment:5 SergeyBiryukov5 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26292:

Fix JSHint errors in image-edit.js.

props dougwollison.
fixes #26000.

comment:6 markoheijnen5 months ago

  • Keywords has-patch commit removed
  • Priority changed from normal to high
  • Resolution fixed deleted
  • Status changed from closed to reopened

This commit broke the ability to save the changed made to an image

markoheijnen5 months ago

comment:7 SergeyBiryukov5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26425:

Fix the ability to save changes made to an image.

props markoheijnen.
fixes #26000.

Note: See TracTickets for help on using tickets.