WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 3 weeks ago

#26021 reopened enhancement

MP6: Custom color schemes don't apply to frontend admin bar.

Reported by: bpetty Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Toolbar Keywords: has-patch
Focuses: ui Cc:
PR Number:

Description

While the custom color schemes apply to the admin bar while in the administration backend, the admin bar reverts back to the default colors on any frontend pages while logged in.

Attachments (1)

26021.patch (541 bytes) - added by sagarprajapati 3 years ago.

Download all attachments as: .zip

Change History (17)

#1 @bpetty
6 years ago

I've made an attempt to fix this myself, but can't seem to wrap my head around how these custom color scheme styles should be enqueued in the frontend for the admin bar, so I'm leaving this to someone more qualified.

#2 @helen
6 years ago

This was on purpose - color clashing, not loading color schemes on the front, etc.

#3 @SergeyBiryukov
6 years ago

  • Keywords needs-patch removed
  • Milestone 3.8 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

#4 @nacin
6 years ago

#26711 was marked as a duplicate.

#5 @johnbillion
4 years ago

  • Component changed from Administration to Toolbar
  • Focuses ui added
  • Keywords needs-patch added
  • Milestone set to Awaiting Review
  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Type changed from defect (bug) to enhancement

We should re-visit this. It's jarring when you visit the front end of your site and the admin toolbar colour scheme changes.

Relevant plugin: https://wordpress.org/plugins/admin-bar-color/

#6 follow-up: @knutsp
4 years ago

-1
I would not want the front toolbar colors to default to the admin toolbar colors.
Plugin material.

#7 in reply to: ↑ 6 @johnbillion
4 years ago

Replying to knutsp:

I would not want the front toolbar colors to default to the admin toolbar colors.

Why not?

#8 @knutsp
4 years ago

The admin toolbar relates to the complete admin color scheme. The front toolbar has to relate to the theme and be visually different. One should not confuse the toolbar with the theme design. The default is dark, and that goes well with most themes. There is no risk of color clash.

Today you may select the admin color scheme completely independent of the site theme, and choose form predefined schemes available. It may come with a deep blue admin toolbar. On the front there may be another kind of blue, and those blue variants may not look good together. So I would have to design my own admin theme with a toolbar that matches the site theme, which may not look good with the rest of the admin theme, and so on. It's a mixup.

In short: The aesthetics will suffer. So please leave this to a plugin.

#9 @DrewAPicture
4 years ago

  • Keywords close added

I'm also -1 on matching the front-end styles for all of the reasons outlined in previous comments. Suggest wontfix.

#10 @morganestes
4 years ago

  • Keywords needs-patch removed
  • Resolution set to wontfix
  • Status changed from reopened to closed

Based on the comments and the fact that there's a plugin available to accomplish this, I'm going to close this for now.

#11 @netweb
4 years ago

  • Milestone Awaiting Review deleted

Sitting on the fence here, I see pros and cons on both sides of this ¯\_(ツ)_/¯

Though, as it's now been closed I'm pulling the milestone :)

#12 @ocean90
3 years ago

#38687 was marked as a duplicate.

#13 @zodiac1978
3 years ago

Some people (like me) are using the color schemes to remind me that I'm using the dev or staging system. For this case it would be helpful to have the color scheme used on the frontend.

(Just to add a real use case reason for changing this behavior.)

#14 @SergeyBiryukov
3 years ago

#40312 was marked as a duplicate.

#15 @sagarprajapati
3 years ago

  • Keywords has-patch added; close removed

Right point @zodiac1978

I have always use the color schemes to remind the dev or staging system. I have attached patch for the solution of above issue. Please check it.

Thanks

#16 @msaggiorato
3 weeks ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Version 3.8 deleted

I think we should revisit this.

I'm also one of the people using color schemes to identify different environments, and having the frontend admin bar not respect the set admin_color setting, is confusing (even not in this use case, for consistency reasons).

Not sure if the patch works nicely with the current version of WP, but we should at least reopen the conversation about this.

Thanks

Note: See TracTickets for help on using tickets.