WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#26023 closed defect (bug) (fixed)

jshint shouldn't throw errors - wp-admin/js/media-upload.js

Reported by: iblamefish Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

Resolving globals: qtags, tinymce.

Made send_to_editor an explicit global (now window.send_to_editor)

Attachments (1)

26023.patch (1.0 KB) - added by iblamefish 5 months ago.

Download all attachments as: .zip

Change History (4)

iblamefish5 months ago

comment:1 iblamefish5 months ago

  • Keywords has-patch added

comment:2 nacin5 months ago

  • Milestone changed from Awaiting Review to 3.8

A note, these globals are only used in read-only context, so true should be omitted.

comment:3 nacin5 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26196:

Fix JSHint errors in media-upload.js.

props iblamefish.
fixes #26023.

Note: See TracTickets for help on using tickets.