WordPress.org

Make WordPress Core

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#26024 closed defect (bug) (fixed)

jshint shouldn't throw errors:wp-includes/js/tinymce/plugins/wplink/editor_plugin_src.js

Reported by: seanchayes Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

2 W109's and 3 W117's

Linting src/wp-includes/js/tinymce/plugins/wplink/editor_plugin_src.js ...ERROR
[L21:C36] W109: Strings must use singlequote.
          height : "auto",
Linting src/wp-includes/js/tinymce/plugins/wplink/editor_plugin_src.js ...ERROR
[L51:C32] W109: Strings must use singlequote.
        version : "1.0"
Linting src/wp-includes/js/tinymce/plugins/wplink/editor_plugin_src.js ...ERROR
[L2:C5] W117: 'tinymce' is not defined.
  tinymce.create('tinymce.plugins.wpLink', {
Linting src/wp-includes/js/tinymce/plugins/wplink/editor_plugin_src.js ...ERROR
[L57:C5] W117: 'tinymce' is not defined.
  tinymce.PluginManager.add('wplink', tinymce.plugins.wpLink);
Linting src/wp-includes/js/tinymce/plugins/wplink/editor_plugin_src.js ...ERROR
[L57:C41] W117: 'tinymce' is not defined.
  tinymce.PluginManager.add('wplink', tinymce.plugins.wpLink);

Attachments (1)

26024.patch (796 bytes) - added by seanchayes 20 months ago.

Download all attachments as: .zip

Change History (4)

@seanchayes20 months ago

comment:1 @seanchayes20 months ago

  • Keywords has-patch added

comment:2 @nacin20 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26201:

Fix JSHint errors in the wpview and wplink editor plugins.

props seanchayes.
fixes #26024, #26027.

comment:3 @nacin20 months ago

  • Milestone changed from Awaiting Review to 3.8

Moving fixed JSHint error tickets to 3.8.

Note: See TracTickets for help on using tickets.