WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26026 closed defect (bug) (fixed)

Dashboard resizing

Reported by: RDall Owned by: helen
Milestone: 3.8 Priority: high
Severity: minor Version: 3.8
Component: Administration Keywords: has-patch needs-testing
Focuses: Cc:
PR Number:

Description

Widgets are getting re-sized with the width of the browser.

Dragging the widgets can also cause the UI to break. See Screenshot

http://cl.ly/image/3u2K0440040N

  1. When dragging the widget from the initial position no dashed lines are actually shown.
  1. But when the widget snaps back to original position the dashed lines then appear and can be moved to another column.

See additional screenshot:

http://cl.ly/image/1y392c2e3X07

Attachments (2)

26026.diff (395 bytes) - added by lessbloat 6 years ago.
26026.1.diff (831 bytes) - added by lessbloat 6 years ago.

Download all attachments as: .zip

Change History (12)

#1 @lessbloat
6 years ago

  • Milestone changed from Awaiting Review to 3.8

Hmm... I can't seem to replicate this. What setup/browser are you using RDall?

#2 @RDall
6 years ago

Here is the setup I grabbed from http://supportdetails.com

Screen Resolution: 2560 x 1440

Web Browser: Firefox 25.0

Browser Size: 1759 x 1149

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:25.0) Gecko/20100101 Firefox/25.0

I was able to drag the widget to the right causing the UI to break on my 17" MBP but the resizing of the browser worked as it should because of the smaller screen I would imagine.

See Screenshot from 17" MBP here:
http://cl.ly/image/2F3J1E3e401E

#3 @lessbloat
6 years ago

I believe 26026.diff​ will remedy this issue.

@lessbloat
6 years ago

#4 @lessbloat
6 years ago

  • Component changed from Appearance to Administration
  • Keywords has-patch needs-testing added; needs-patch removed
  • Severity changed from normal to minor

#5 @matt
6 years ago

  • Priority changed from normal to high

#6 @helen
6 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 26372:

Contain Dashboard widget dragging. props lessbloat. fixes #26026.

#7 follow-up: @azaozz
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Setting containment for the postboxes to #dashboard-widgets-wrap makes them very hard to move in some cases. If you try to move the tallest postbox, it cannot be moved up or down at all making it impossible to place properly.

Setting containment to document fixes this.

Last edited 6 years ago by azaozz (previous) (diff)

#8 @azaozz
6 years ago

Also, the min-height of the sortable containers is not there any more. When the last postbox is dragged out, the container shrinks to 0 making it impossible to drag the postbox back in.

@lessbloat
6 years ago

#9 in reply to: ↑ 7 @lessbloat
6 years ago

Replying to azaozz:

Setting containment for the postboxes to #dashboard-widgets-wrap makes them very hard to move in some cases. If you try to move the tallest postbox, it cannot be moved up or down at all making it impossible to place properly.
Setting containment to document fixes this.

Also, the min-height of the sortable containers is not there any more. When the last postbox is dragged out, the container shrinks to 0 making it impossible to drag the postbox back in.

Good catch. 26026.1.diff​ should do it then.

#10 @azaozz
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26429:

Dashboard: set containment for postboxes to "document" and give empty sortables some min-height so postboxes can be dropped there. Props lessbloat, fixes #26026.

Note: See TracTickets for help on using tickets.