jshint shouldn't throw errors: wp-admin/js/wp-fullscreen.js

[dougwollison]

Patch to come

[dougwollison]

Initial changes: spacing, braces, equals, keys fixed and globals declared.

[dougwollison]

Revised declaration of globals.

[dougwollison]

Just the jshint fixes.

[mattwiebe]

@dougwollison your patches seem to have used basic jshint rather than grunt jshint:core --file=wp-fullscreen.js as instructed in the ​make/core post. The grunt version ignores eqeqeq and curly options for now, since there were too many of those errors to get in for this round.

I've attached a patch that ignores eqeqeq and curly errors. Also note that the file settles on tinymce rather than tinyMCE as the preferred global namespace in accordance with ​their docs.

[MattyRob]

I have patched and tested 26029.4.diff and 26029.2.diff. Both appear to work fine to me.

On one hand I can see the need to apply these broad patches a little at a time and not worrying about everything now but then part of me also things if that patch file exists and seems okay why not commit now rather than deferring and doing it later.

UPDATE: The 26029.4.diff may be the better one to use as the other patch I tested leaves 2 unresolved errors.

[nacin]

tinymcePreInit is supposed to be tinyMCEPreInit, even though tinyMCE is tinymce.

[nacin]

In 26667:

Define globals and add semicolons to wp-fullscreen.js.

grunt jshint now runs clean for WordPress core!

props mattwiebe.
fixes #26029.