WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#26040 closed defect (bug) (fixed)

jshint shouldn't throw errors: wp-includes/js/customize-loader.js

Reported by: mdbitz Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

jshint cleanup of wp-includes/js/customize-loader.js

W117 : '_wpCustomizeLoaderSettings' is not defined
W098 : 'e' is defined but never used

Attachments (1)

26040.patch (584 bytes) - added by mdbitz 5 months ago.
jshint cleanup of customize-loader (global and unused named function param)

Download all attachments as: .zip

Change History (3)

mdbitz5 months ago

jshint cleanup of customize-loader (global and unused named function param)

comment:1 nacin5 months ago

  • Milestone changed from Awaiting Review to 3.8

Thanks!

We've been omitting :false for read-only globals. If false makes more sense, we can change it project-wide, but it's more verbose (and some of these files currently have a lot of globals).

comment:2 nacin5 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26194:

Fix JSHint errors for customize-loader.

props mdbitz.
fixes #26040.

Note: See TracTickets for help on using tickets.