WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#26046 closed defect (bug) (fixed)

jshint shouldn’t throw errors - wp-includes/js/quicktags.js

Reported by: kovshenin Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

Let's fix jshint errors for quicktags.js. The arguments.callee part might be tricky.

Attachments (1)

26046.diff (11.4 KB) - added by kovshenin 5 months ago.

Download all attachments as: .zip

Change History (5)

kovshenin5 months ago

comment:1 kovshenin5 months ago

  • Summary changed from JSHint: wp-includes/js/quicktags.js to jshint shouldn’t throw errors - wp-includes/js/quicktags.js

comment:2 nacin5 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26212:

Fix JSHint errors in quicktags.js. Ignore deprecated API rather than marking it as exported globals.

props kovshenin.
fixes #26046.

comment:3 SergeyBiryukov5 months ago

  • Milestone changed from Awaiting Review to 3.8

comment:4 azaozz5 months ago

In 26553:

Quicktags: fix int/string strict comparison, see #26046.

Note: See TracTickets for help on using tickets.