WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26049 closed defect (bug) (fixed)

Hook Docs (21): wp-includes/class-http.php

Reported by: kraftbj's profile kraftbj Owned by: drewapicture's profile DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: HTTP API Keywords: has-patch
Focuses: docs Cc:

Description (last modified by kpdesign)

Holding ticket for upcoming inline docs patch for wp-includes/class-http.php

Attachments (5)

26049-1.patch​ (1.5 KB) - added by kraftbj 11 years ago.
Patch of do_action* hooks documented. TODO: Filters
26049-2.patch​ (8.6 KB) - added by kraftbj 11 years ago.
All hooks in /wp-includes/class-http.php documented.
26049-3.patch​ (9.5 KB) - added by kpdesign 11 years ago.
First pass on 26049-2.patch
26049.patch​ (10.1 KB) - added by DrewAPicture 11 years ago.
2nd pass
26049.1.patch​ (10.2 KB) - added by kpdesign 11 years ago.
Third pass

Download all attachments as: .zip

Change History (15)

@kraftbj
11 years ago

Patch of do_action* hooks documented. TODO: Filters

#1 @kpdesign
11 years ago

  • Description modified (diff)
  • Owner set to kpdesign
  • Status changed from new to reviewing
  • Summary changed from Hook Docs: /wp-includes/class-http.php to Hook Docs: wp-includes/class-http.php

#2 @DrewAPicture
11 years ago

  • Keywords needs-patch added
  • Summary changed from Hook Docs: wp-includes/class-http.php to Hook Docs (21): wp-includes/class-http.php

Still needs a complete patch including the filters. Will take a closer look at the sprint tomorrow.

#3 @kraftbj
11 years ago

I've been taking my sweet time, doing a bit at a time. I'll finish this up today or tomorrow.

@kraftbj
11 years ago

All hooks in /wp-includes/class-http.php documented.

#4 @kraftbj
11 years ago

  • Keywords has-patch added; needs-patch removed

@kpdesign
11 years ago

First pass on 26049-2.patch

#5 @kpdesign
11 years ago

  • Keywords docs-feedback added

26049-3.patch​ fixes some formatting issues, and changes some descriptions for language consistency.

#6 @kraftbj
11 years ago

Thanks for updating the patch. I'll review it to learn for the next one.

@DrewAPicture
11 years ago

2nd pass

#7 @DrewAPicture
11 years ago

  • Keywords docs-feedback removed
  • Milestone changed from Awaiting Review to 3.9
  • Owner changed from kpdesign to DrewAPicture

26049.patch​ improves many descriptions and parameter descriptions from 26049-3.patch​.

Last edited 11 years ago by DrewAPicture (previous) (diff)

#8 @jeremyfelt
11 years ago

  • Component changed from Inline Docs to HTTP
  • Focuses docs added

@kpdesign
11 years ago

Third pass

#9 @kpdesign
11 years ago

26049.1.patch​ incorporates some minor changes (typos, better docs-specific variables) to 26049.patch​.

@DrewAPicture - I think we've got a commit candidate with this one. What do you think?

#10 @DrewAPicture
11 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27049:

Inline documentation for hooks in wp-includes/class-http.php.

Props kraftbj for the initial patches. Props kpdesign, DrewAPicture.
Fixes #26049.

Note: See TracTickets for help on using tickets.