WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#26057 closed defect (bug) (fixed)

Remove redundant current_user_can() check in site-new.php

Reported by: jeremyfelt Owned by: SergeyBiryukov
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.1
Component: Network Admin Keywords: has-patch
Focuses: multisite Cc:

Description

When site-new.php was created in [15886], a current_user_can( 'manage_sites' ) was moved over from the add-blog case in edit.php and a new check was added at the top of the file. The check inside the add-blog action is not required anymore as it will never be false.

Attachments (1)

26057.diff (607 bytes) - added by jeremyfelt 7 years ago.

Download all attachments as: .zip

Change History (3)

@jeremyfelt
7 years ago

#1 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 3.8

#2 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26236:

Remove redundant current_user_can() check. props jeremyfelt. fixes #26057.

Note: See TracTickets for help on using tickets.