WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#26059 closed enhancement (fixed)

styling of span class item-controls is a bit off

Reported by: senlin Owned by: iammattthomas
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Menus Keywords: has-patch
Focuses: ui Cc:

Description

I have noticed that the menu items in the menu structure are a bit off.

https://www.evernote.com/shard/s19/sh/5d2b1e4c-3505-4be9-b997-bd47b351e4ca/1c7305da46ce2d995e7b14135dc9e72a/deep/0/item-type-off.png

This can be fixed with the following:

  • line 9178 of wp-admin/css/wp-admin.css give the .item-type class a line-height of 18px instead of 22px
  • line 9072 of wp-admin/css/wp-admin.css give the .menu-item-bar .menu-item-handle class a line-height of 30px instead of 35px
  • remove lines 10434-10437 completely from wp-admin/css/wp-admin.css

https://www.evernote.com/shard/s19/sh/e6d48891-fc59-46ab-bbce-44fed8b4638b/443f7d9e586478f449b9619fd20bba34/deep/0/item-type-fixed.png

I'm really sorry, I don't know (yet) how to add a diff file here, hence my elaborated message.

Attachments (3)

26059.diff (762 bytes) - added by jeremyfelt 8 years ago.
26059.2.diff (1.4 KB) - added by senlin 8 years ago.
both wp-admin.css and wp-admin-rtl.css
26059.min.diff (655.3 KB) - added by senlin 8 years ago.
these are the two minified files (wp-admin.min.css and wp-admin-rtl.min.css)

Download all attachments as: .zip

Change History (9)

@jeremyfelt
8 years ago

#1 @jeremyfelt
8 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.8
  • Version set to trunk

26059.diff is a patch with the changes to wp-admin.css described by @senlin in the ticket description. These correct the spacing issues in Chrome 31.0.1650.57 on OSX for me.

Thanks for the detailed info, @senlin! If you haven't yet, check out the submitting a patch page for a few methods to create patches depending on your setup.

#2 follow-up: @senlin
8 years ago

It also needs to be done in wp-admin-rtl.css and the minified files

I'm actually on my way with the patch, but I have updated to OSX Mavericks and svn doesn't work anymore with terminal. Usually I use the SCPlugin, but that one doesn't seem to have the possibility to create a patch; any suggestions welcome as this would be my very first core patch ever :)

Last edited 8 years ago by senlin (previous) (diff)

@senlin
8 years ago

both wp-admin.css and wp-admin-rtl.css

@senlin
8 years ago

these are the two minified files (wp-admin.min.css and wp-admin-rtl.min.css)

#3 in reply to: ↑ 2 ; follow-up: @SergeyBiryukov
8 years ago

  • Keywords ui-focus added

Replying to senlin:

It also needs to be done in wp-admin-rtl.css and the minified files

Actually, only unminified files should be patched. Minified ones are regenerated automatically, and now RTL ones should be as well (see #24977).

#4 in reply to: ↑ 3 @senlin
8 years ago

Replying to SergeyBiryukov:

... and now RTL ones should be as well (see #24977).

Oh, that's pretty amazing. Thanks for showing me.

#5 @seanchayes
8 years ago

After applying the patch (only to wp-admin.css - I didn't have wp-admin-rtl.css on my system) in trunk I see the change pictured in the description - the twistie / triangle is better aligned with the text on it's left. (Or the text is better aligned with the twistie / triangle on it's right).

I used Chrome 32 and Firefox 25 on Windows.

#6 @iammattthomas
8 years ago

  • Owner set to iammattthomas
  • Resolution set to fixed
  • Status changed from new to closed

In 26256:

Make the item-controls elements on the Edit Menus page line up; use :before instead of :after for item-edit icons for better cross-browser performance; switch to :after instead of ::after for pseudo-elements so IE8 displays these icons properly. Fixes #26059, props jeremyfelt.

Note: See TracTickets for help on using tickets.