styling of span class item-controls is a bit off

[senlin]

I have noticed that the menu items in the menu structure are a bit off.

This can be fixed with the following:

• line 9178 of wp-admin/css/wp-admin.css give the .item-type class a line-height of 18px instead of 22px
• line 9072 of wp-admin/css/wp-admin.css give the .menu-item-bar .menu-item-handle class a line-height of 30px instead of 35px
• remove lines 10434-10437 completely from wp-admin/css/wp-admin.css

I'm really sorry, I don't know (yet) how to add a diff file here, hence my elaborated message.

[jeremyfelt]

26059.diff​ is a patch with the changes to wp-admin.css described by @senlin in the ticket description. These correct the spacing issues in Chrome 31.0.1650.57 on OSX for me.

Thanks for the detailed info, @senlin! If you haven't yet, check out the ​submitting a patch page for a few methods to create patches depending on your setup.

[senlin]

It also needs to be done in wp-admin-rtl.css and the minified files

I'm actually on my way with the patch, but I have updated to OSX Mavericks and svn doesn't work anymore with terminal. Usually I use the SCPlugin, but that one doesn't seem to have the possibility to create a patch; any suggestions welcome as this would be my very first core patch ever :)

[senlin]

both wp-admin.css and wp-admin-rtl.css

[senlin]

these are the two minified files (wp-admin.min.css and wp-admin-rtl.min.css)

[SergeyBiryukov]

Replying to senlin:

It also needs to be done in wp-admin-rtl.css and the minified files

Actually, only unminified files should be patched. Minified ones are regenerated automatically, and now RTL ones should be as well (see #24977).

[senlin]

Replying to SergeyBiryukov:

... and now RTL ones should be as well (see #24977).

Oh, that's pretty amazing. Thanks for showing me.

[seanchayes]

After applying the patch (only to wp-admin.css - I didn't have wp-admin-rtl.css on my system) in trunk I see the change pictured in the description - the twistie / triangle is better aligned with the text on it's left. (Or the text is better aligned with the twistie / triangle on it's right).

I used Chrome 32 and Firefox 25 on Windows.

[iammattthomas]

In 26256:

Make the item-controls elements on the Edit Menus page line up; use :before instead of :after for item-edit icons for better cross-browser performance; switch to :after instead of ::after for pseudo-elements so IE8 displays these icons properly. Fixes #26059, props jeremyfelt.