WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#26063 closed defect (bug) (fixed)

Invisible characters in the admin in Opera 12

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 3.8 Priority: highest omg bbq
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch
Focuses: ui Cc:

Description

See the screenshot.

If the loaded font subset doesn't contain some characters (bold Cyrillic characters in this case), Opera fails to apply the standard serif font and displays nothing instead. This was extensively tested for Twenty Twelve in #21751 and #21775.

The solution is to load the correct font subset: tags/3.7.1/src/wp-content/themes/twentytwelve/functions.php#L98.

We should probably also add the ability for translators to disable Open Sans, like we did for Twenty Twelve.

Attachments (4)

26063.png (34.4 KB) - added by SergeyBiryukov 6 years ago.
26063.patch (1.3 KB) - added by SergeyBiryukov 6 years ago.
26063.after.png (37.2 KB) - added by SergeyBiryukov 6 years ago.
26063.2.patch (2.2 KB) - added by dimadin 6 years ago.

Download all attachments as: .zip

Change History (18)

@SergeyBiryukov
6 years ago

#1 @SergeyBiryukov
6 years ago

  • Keywords ui-focus added

#3 @dimadin
6 years ago

  • Cc forumi@… added

#4 @iammattthomas
6 years ago

In 26254:

Load the correct subset of Open Sans for cyrillic, greek, and vietnamese in addition to latin and latin-ext; following the example of Twenty Twelve. See #26063, props SergeyBiryukov.

#5 @iammattthomas
6 years ago

Thanks Sergey; I'd been meaning to steal this logic from Twenty Twelve. Even if we decide to bundle, we'll still want to include this if we give people the option of linking, plus it fixes the issue immediately and bundling still has a number of open questions.

#6 @iammattthomas
6 years ago

Left this ticket open for the option to disable Open Sans for translations.

#7 @matt
6 years ago

  • Priority changed from normal to highest omg bbq

Let's get a way to disable Open Sans for translations in this week or table it for 3.8.1.

@dimadin
6 years ago

#8 @dimadin
6 years ago

Attached patch implements disabling from translations as it's done in Twenty Twelve, Twenty Thirteen and Twenty Fourteen. Also changes to new braces style for subsets and uses add_query_arg().

#9 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26376:

Allow Open Sans to be disabled per language. props dimadin. fixes #26063.

#10 @dd32
6 years ago

We can't use add_query_arg() in script-loader, infact, we have to avoid as many functions as possible.

This is because we include script-loader.php within wp-admin/load-styles.php for style concatenation in build versions.

Fatal error: Call to undefined function add_query_arg() in build/wp-includes/script-loader.php on line 588

Fix incoming.

#11 @dd32
6 years ago

In 26381:

Revert the change to use add_query_arg() for Open Sans, as it causes a fatal error when script concatenation is used. See #26063

#12 @dimadin
6 years ago

Sorry, guys! I haven't thought about this. Obviously src version had no problems when I tried.

#13 @dimadin
6 years ago

(cross posted from make/core comment)
I have coded a simple plugin that disables loading of Open Sans from Google's servers using feature introduced in [26376]. If you have any comments about it (including its name), please share and I'll submit it to repository in a few days.

This ticket was mentioned in IRC in #wordpress-dev by SergeyBiryukov. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.