#26063 closed defect (bug) (fixed)
Invisible characters in the admin in Opera 12
Reported by: | SergeyBiryukov | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 3.8 | Priority: | highest omg bbq |
Severity: | normal | Version: | 3.8 |
Component: | Administration | Keywords: | has-patch |
Focuses: | ui | Cc: |
Description
See the screenshot.
If the loaded font subset doesn't contain some characters (bold Cyrillic characters in this case), Opera fails to apply the standard serif font and displays nothing instead. This was extensively tested for Twenty Twelve in #21751 and #21775.
The solution is to load the correct font subset: tags/3.7.1/src/wp-content/themes/twentytwelve/functions.php#L98.
We should probably also add the ability for translators to disable Open Sans, like we did for Twenty Twelve.
Attachments (4)
Change History (18)
#5
@
11 years ago
Thanks Sergey; I'd been meaning to steal this logic from Twenty Twelve. Even if we decide to bundle, we'll still want to include this if we give people the option of linking, plus it fixes the issue immediately and bundling still has a number of open questions.
#7
@
11 years ago
- Priority changed from normal to highest omg bbq
Let's get a way to disable Open Sans for translations in this week or table it for 3.8.1.
#8
@
11 years ago
Attached patch implements disabling from translations as it's done in Twenty Twelve, Twenty Thirteen and Twenty Fourteen. Also changes to new braces style for subsets and uses add_query_arg()
.
#9
@
11 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 26376:
#10
@
11 years ago
We can't use add_query_arg()
in script-loader, infact, we have to avoid as many functions as possible.
This is because we include script-loader.php
within wp-admin/load-styles.php
for style concatenation in build versions.
Fatal error: Call to undefined function add_query_arg() in build/wp-includes/script-loader.php on line 588
Fix incoming.
#12
@
11 years ago
Sorry, guys! I haven't thought about this. Obviously src version had no problems when I tried.
#13
@
11 years ago
(cross posted from make/core comment)
I have coded a simple plugin that disables loading of Open Sans from Google's servers using feature introduced in [26376]. If you have any comments about it (including its name), please share and I'll submit it to repository in a few days.
Related: #26072