Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#26071 closed enhancement (fixed)

MP6: Edit and View links in admin toolbar

Reported by: johnbillion's profile johnbillion Owned by: iammattthomas's profile iammattthomas
Milestone: 3.8 Priority: lowest
Severity: minor Version: 3.8
Component: Administration Keywords:
Focuses: ui Cc:


The "Edit Post" and "View Post' links in the admin toolbar are oddities. They are the only links that don't turn into icons at smaller screen sizes, and they disappear altogether in the <480px media query which is triggered on a portrait smartphone. Of the two, the Edit Post link is the most frustrating when it disappears.

We should:

  • Implement icons for the Edit Post and View Post links
  • Not hide the Edit Post link on the front end
  • Probably not hide the View Post link in the admin area

If we're short on space at narrower screen sizes then we should hide the WordPress menu before we hide the Edit Post link. (Arguably the WordPress icon is a waste of space on narrower screen sizes anyway.)

Change History (8)

#1 @zerodegreeburn
10 years ago

I agree. Lots of people will be wanting to edit posts on mobiles so an edit icon would be great. There is space for it, just :)

However, in the backend at 320px there is literally no space left for another icon, but I don't think this is such an issue as there is a view post link next to change permalinks.

#2 @matt
10 years ago

  • Priority changed from normal to lowest
  • Severity changed from normal to minor
  • Type changed from defect (bug) to enhancement

#3 @iammattthomas
10 years ago

Agreed on adding an icon to Edit Post/View Post. We need to make a decision anyway about which icons to drop for mobile, so we can use this ticket.

We've got space for 6 icons in the toolbar on an iPhone, the smallest handset viewport we account for. We've currently got:

  • W menu
  • Network menu
  • Site menu
  • Comments shortcut
  • New menu
  • My Account menu
  • Responsive sidebar toggle (the "hamburger button"), admin only

We already need to eliminate one of these in the admin in order to make everything fit when multisite is enabled. We'll need to hide two in order to make room for the View link. Hiding the Network menu would be easiest, then there'd be no difference to account for when multisite is enabled. It's arguably more useful than the Comments shortcut though, so let's see if there are any strong opinions one way or the other. I agree that it probably makes sense to hide the W menu as well, it's the least useful of all of these (though too bad about having to lose the logo).

#4 @helen
10 years ago

I think we can leave out View Post in the admin - there are other links to view the post in the admin. Themes usually include an edit link, but not necessarily in a consistent place, so I think an Edit link would be a good idea.

As for another item to drop in the admin, I guess it should be the W menu.

#5 @nacin
10 years ago

The Network menu is the only way to get to the network admin, so it has to stay. Absolute must haves are the Network menu, the Site menu, and the Account menu. Everything else is fungible. The hamburger is needed in the admin, so we can include the Edit icon on the frontend (and let's not use View in the admin). That leaves two slots in single site, one in multisite.

At least one other menu is also missing from the list — updates, when one is pending.

Things to choose from: search, new, comments, updates, W menu.

I would go for new and comments in single site. In multisite, it's a toss-up. I'd show comments if there are any pending, otherwise show new.

#6 @nacin
10 years ago

  • Owner set to iammattthomas
  • Status changed from new to assigned

#7 @iammattthomas
10 years ago

In 26559:

Give the adminbar Edit Post link an icon, and make it visible on small screen responsive states. See #26071.

#8 @iammattthomas
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 26575:

Changes to the mobile adminbar:

  • Unhide the Edit link
  • Hide the W menu link
  • Hide the Updates link

This ensures that Network (when available), Site, Edit, Comments, New, and Account are always visible. Fixes #26071.

Note: See TracTickets for help on using tickets.