Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26073 closed enhancement (fixed)

Update versions of Grunt modules in package.json

Reported by: tobiasbg's profile TobiasBg Owned by: wonderboymusic's profile wonderboymusic
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch 3.9-early
Focuses: Cc:

Description

Since adopting Grunt, several Grunt modules that are listed in package.json have been updated. The attached patch updates their version numbers in package.json, so that we can benefit from the respective up-to-date and stable versions.

Attachments (5)

26073.patch (849 bytes) - added by TobiasBg 11 years ago.
Update Grunt modules
26073.2.patch (1.1 KB) - added by TobiasBg 11 years ago.
26073.3.diff (1.2 KB) - added by mjbanks 11 years ago.
Updated to latest package versions as of Jan. 17
26073.4.patch (1.1 KB) - added by TobiasBg 11 years ago.
Refreshed patch, Jan. 19
26073.5.patch (1.2 KB) - added by yoavf 11 years ago.

Download all attachments as: .zip

Change History (13)

@TobiasBg
11 years ago

Update Grunt modules

#1 @SergeyBiryukov
11 years ago

  • Component changed from General to Build Tools

@TobiasBg
11 years ago

#2 @TobiasBg
11 years ago

The refreshed 26073.2.patch has the latest versions.

#3 @TobiasBg
11 years ago

  • Keywords 3.9-early added

#4 @SergeyBiryukov
11 years ago

  • Milestone changed from Awaiting Review to 3.9

@mjbanks
11 years ago

Updated to latest package versions as of Jan. 17

@TobiasBg
11 years ago

Refreshed patch, Jan. 19

#5 @TobiasBg
11 years ago

@mjbanks: Thanks for the refreshed patch! Unfortunately, it seems to be breaking some stuff (remove grunt-contrib-copy, add a second line for grunt), and it doesn't yet take [26977] into account (which happened just one hour after you submitted your patch), so I refreshed the patch again, see 26073.4.patch.

#6 @mjbanks
11 years ago

@TobiasBg - ah good call!

@yoavf
11 years ago

#7 @yoavf
11 years ago

I updated the patch with 26073.5.patch, as I've just released grunt-cssjanus 0.2.2 - we no longer need our fork there.
Tested by comparing RTL files output pre/after patch - no diffs.

Last edited 11 years ago by yoavf (previous) (diff)

#8 @wonderboymusic
11 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 27053:

Update the versions of several devDependencies in package.json. grunt-cssjanus has been updated to 0.2.2, we no longer need the fork. Run npm install to receive updates for node_modules in the project root.

Props yoavf, TobiasBg.
Fixes #26073.

Note: See TracTickets for help on using tickets.