WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 5 months ago

#26073 closed enhancement (fixed)

Update versions of Grunt modules in package.json

Reported by: TobiasBg Owned by: wonderboymusic
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch 3.9-early
Focuses: Cc:

Description

Since adopting Grunt, several Grunt modules that are listed in package.json have been updated. The attached patch updates their version numbers in package.json, so that we can benefit from the respective up-to-date and stable versions.

Attachments (5)

26073.patch (849 bytes) - added by TobiasBg 8 months ago.
Update Grunt modules
26073.2.patch (1.1 KB) - added by TobiasBg 7 months ago.
26073.3.diff (1.2 KB) - added by mjbanks 6 months ago.
Updated to latest package versions as of Jan. 17
26073.4.patch (1.1 KB) - added by TobiasBg 6 months ago.
Refreshed patch, Jan. 19
26073.5.patch (1.2 KB) - added by yoavf 5 months ago.

Download all attachments as: .zip

Change History (13)

TobiasBg8 months ago

Update Grunt modules

comment:1 SergeyBiryukov8 months ago

  • Component changed from General to Build Tools

TobiasBg7 months ago

comment:2 TobiasBg7 months ago

The refreshed 26073.2.patch has the latest versions.

comment:3 TobiasBg7 months ago

  • Keywords 3.9-early added

comment:4 SergeyBiryukov7 months ago

  • Milestone changed from Awaiting Review to 3.9

mjbanks6 months ago

Updated to latest package versions as of Jan. 17

TobiasBg6 months ago

Refreshed patch, Jan. 19

comment:5 TobiasBg6 months ago

@mjbanks: Thanks for the refreshed patch! Unfortunately, it seems to be breaking some stuff (remove grunt-contrib-copy, add a second line for grunt), and it doesn't yet take [26977] into account (which happened just one hour after you submitted your patch), so I refreshed the patch again, see 26073.4.patch.

comment:6 mjbanks6 months ago

@TobiasBg - ah good call!

yoavf5 months ago

comment:7 yoavf5 months ago

I updated the patch with 26073.5.patch, as I've just released grunt-cssjanus 0.2.2 - we no longer need our fork there.
Tested by comparing RTL files output pre/after patch - no diffs.

Last edited 5 months ago by yoavf (previous) (diff)

comment:8 wonderboymusic5 months ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 27053:

Update the versions of several devDependencies in package.json. grunt-cssjanus has been updated to 0.2.2, we no longer need the fork. Run npm install to receive updates for node_modules in the project root.

Props yoavf, TobiasBg.
Fixes #26073.

Note: See TracTickets for help on using tickets.