Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#26075 closed defect (bug) (fixed)

Hook Docs (4): wp-admin/media-upload.php

Reported by: piontkowski Owned by: kpdesign
Priority: normal Milestone: 3.9
Component: Media Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: docs

Description

Attached patch has inline docs for media_upload_default_type and media_upload_default_tab filters and media_upload_$type and media_upload_$tab actions.

Attachments (2)

26075.diff (1.2 KB ) - added by piontkowski 13 years ago.
26075.2.diff (2.5 KB ) - added by DrewAPicture 13 years ago.
Complete pass.

Download all attachments as: .zip

Change History (9)

@piontkowski
13 years ago

#1 @piontkowski
13 years ago

  • Keywords has-patch added

#2 @DrewAPicture
13 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to kpdesign
  • Status newreviewing
  • Summary Hook Docs: wp-admin/media-upload.phpHook Docs (4): wp-admin/media-upload.php

Thanks for the patch. Looks like you missed documenting the single parameters in the media_upload_default_type and media_upload_default_tab filters. Also, some of the spacing and wrapping is a little bit off. Should be able to wrap this one up today during the sprint.

@DrewAPicture
13 years ago

Complete pass.

#3 @DrewAPicture
13 years ago

  • Keywords has-patch docs-feedback added; needs-patch removed
  • Milestone Awaiting Review3.9

26075.2.diff is a complete re-pass of these hooks. It attempts to navigate the complex conditions under which the media_upload_$type and media_upload_$tab hooks fire. The language needs a secondary review.

#4 @kpdesign
13 years ago

  • Keywords commit added; docs-feedback removed

26075.2 looks good. Recommend commit.

#5 @DrewAPicture
13 years ago

  • Resolutionfixed
  • Status reviewingclosed

In 26917:

Inline documentation for hooks in wp-admin/media-upload.php.

Props piontkowski for the initial patch.
Fixes #26075.

#6 @DrewAPicture
13 years ago

  • Focuses docs added

#7 @DrewAPicture
13 years ago

  • Component Inline DocsMedia
Note: See TracTickets for help on using tickets.