#26075 closed defect (bug) (fixed)
Hook Docs (4): wp-admin/media-upload.php
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.9 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Media | Keywords: | has-patch commit |
| Focuses: | docs | Cc: |
Description
Attached patch has inline docs for media_upload_default_type and media_upload_default_tab filters and media_upload_$type and media_upload_$tab actions.
Attachments (2)
Change History (9)
@piontkowski
4 years ago
#1
@piontkowski
4 years ago
- Keywords has-patch added
#2
@DrewAPicture
4 years ago
- Keywords needs-patch added; has-patch removed
- Owner set to kpdesign
- Status changed from new to reviewing
- Summary changed from Hook Docs: wp-admin/media-upload.php to Hook Docs (4): wp-admin/media-upload.php
#3
@DrewAPicture
4 years ago
- Keywords has-patch docs-feedback added; needs-patch removed
- Milestone changed from Awaiting Review to 3.9
26075.2.diff is a complete re-pass of these hooks. It attempts to navigate the complex conditions under which the media_upload_$type and media_upload_$tab hooks fire. The language needs a secondary review.
#4
@kpdesign
4 years ago
- Keywords commit added; docs-feedback removed
26075.2 looks good. Recommend commit.
#5
@DrewAPicture
4 years ago
- Resolution set to fixed
- Status changed from reviewing to closed
In 26917:
#6
@DrewAPicture
4 years ago
- Focuses docs added
#7
@DrewAPicture
4 years ago
- Component changed from Inline Docs to Media
Note: See
TracTickets for help on using
tickets.
Thanks for the patch. Looks like you missed documenting the single parameters in the media_upload_default_type and media_upload_default_tab filters. Also, some of the spacing and wrapping is a little bit off. Should be able to wrap this one up today during the sprint.