Make WordPress Core

Opened 2 years ago

Closed 23 months ago

Last modified 21 months ago

#26075 closed defect (bug) (fixed)

Hook Docs (4): wp-admin/media-upload.php

Reported by: piontkowski Owned by: kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch commit
Focuses: docs Cc:


Attached patch has inline docs for media_upload_default_type and media_upload_default_tab filters and media_upload_$type and media_upload_$tab actions.

Attachments (2)

26075.diff (1.2 KB) - added by piontkowski 2 years ago.
26075.2.diff (2.5 KB) - added by DrewAPicture 23 months ago.
Complete pass.

Download all attachments as: .zip

Change History (9)

2 years ago

#1 @piontkowski
2 years ago

  • Keywords has-patch added

#2 @DrewAPicture
2 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to kpdesign
  • Status changed from new to reviewing
  • Summary changed from Hook Docs: wp-admin/media-upload.php to Hook Docs (4): wp-admin/media-upload.php

Thanks for the patch. Looks like you missed documenting the single parameters in the media_upload_default_type and media_upload_default_tab filters. Also, some of the spacing and wrapping is a little bit off. Should be able to wrap this one up today during the sprint.

23 months ago

Complete pass.

#3 @DrewAPicture
23 months ago

  • Keywords has-patch docs-feedback added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.9

26075.2.diff is a complete re-pass of these hooks. It attempts to navigate the complex conditions under which the media_upload_$type and media_upload_$tab hooks fire. The language needs a secondary review.

#4 @kpdesign
23 months ago

  • Keywords commit added; docs-feedback removed

26075.2 looks good. Recommend commit.

#5 @DrewAPicture
23 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26917:

Inline documentation for hooks in wp-admin/media-upload.php.

Props piontkowski for the initial patch.
Fixes #26075.

#6 @DrewAPicture
21 months ago

  • Focuses docs added

#7 @DrewAPicture
21 months ago

  • Component changed from Inline Docs to Media
Note: See TracTickets for help on using tickets.