No update links on themes.php

[dd32]

The new Themes pages include a "Update available" notification, but doesn't include any links to update the theme.

In addition, the notice in the Theme dialogue about the new version being available is a bit short and terse, it was perfect when it was a small 1-liner under the theme, but feels out of place in the new UI:

[matveb]

This wasn't merged with the rest because THX was forking the core function for theme updates — but it's marked for inclusion.

​http://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/theme.php#L394

The way it looked on the plugin:

[dd32]

In 26282:

Themes: Add a get_theme_update_available() function to retrieve an update link and use it on the Themes page. See #26078

[dd32]

The thickbox size is way out after that commit for the new version details, so still needs it's proper styling fixed.

[matveb]

I think we can remove the thickbox and open a new window instead.

[dd32]

#26138 was marked as a duplicate.

[SergeyBiryukov]

Replying to dd32:

The thickbox size is way out after that commit for the new version details, so still needs it's proper styling fixed.

Previously fixed in [24558]. Re-broken in [26141], which copied theme.js file into theme-install.js and replaced the file with a new one.

If we want to keep the thickbox, we can either re-add the code we had in theme.js (26078.thickbox.patch​), or enqueue theme-install.js along with theme.js (26078.thickbox.2.patch​).

Related: #26140

[dd32]

I am usually surprised that each screen has to handle the thickbox sizing manually.. That being said, I'd just enqueue both for now I think

[SergeyBiryukov]

Install Themes screen doesn't actually use thickbox, only Manage Themes does.

Looks like we should move the code back to theme.js and remove it from theme-install.js. ticket:26140:26140.2.patch​ does that.

[SergeyBiryukov]

In 26323:

Fix thickbox positioning on Manage Themes screen. Adjust thickbox resizing code on various screens for new toolbar height.

see #26078. fixes #26140.

[SergeyBiryukov]

Anything left here?