WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 3 months ago

Last modified 7 weeks ago

#26092 closed defect (bug) (fixed)

Hook Docs (9): wp-admin/includes/meta-boxes.php

Reported by: SpencerFinnell Owned by: kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: docs Cc:

Description

Hook/filter documentation in wp-admin/includes/meta-boxes.php

Attachments (2)

26092.patch (5.3 KB) - added by SpencerFinnell 5 months ago.
26092.2.patch (4.3 KB) - added by DrewAPicture 3 months ago.
Second pass.

Download all attachments as: .zip

Change History (9)

SpencerFinnell5 months ago

comment:1 kpdesign5 months ago

  • Owner set to kpdesign
  • Status changed from new to reviewing

comment:2 DrewAPicture4 months ago

  • Keywords needs-patch added; has-patch removed
  • Summary changed from Hooks Docs: wp-admin/includes/meta-boxes.php to Hook Docs (9): wp-admin/includes/meta-boxes.php

26092.patch is a great starting patch. Two things that jumped out at me are some needed spacing and wrapping on the page_attributes_dropdown_pages_args hook, and all versions should use the 3-digit x.x.x style.

DrewAPicture3 months ago

Second pass.

comment:3 DrewAPicture3 months ago

  • Keywords has-patch docs-feedback added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.9

26092.2.patch is a second pass. Could use a once-over, especially on the actions that fire inside various meta boxes.

comment:4 kpdesign3 months ago

  • Keywords commit added; docs-feedback removed

26092.2.patch looks good. Recommend commit.

comment:5 DrewAPicture3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26918:

Inline documentation for hooks in wp-admin/includes/meta-boxes.php.

Props SpencerFinnell for the initial patch.
Fixes #26092.

comment:6 DrewAPicture7 weeks ago

  • Focuses docs added

comment:7 DrewAPicture7 weeks ago

  • Component changed from Inline Docs to Editor
Note: See TracTickets for help on using tickets.