Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26092 closed defect (bug) (fixed)

Hook Docs (9): wp-admin/includes/meta-boxes.php

Reported by: SpencerFinnell Owned by: kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: docs Cc:


Hook/filter documentation in wp-admin/includes/meta-boxes.php

Attachments (2)

26092.patch (5.3 KB) - added by SpencerFinnell 4 years ago.
26092.2.patch (4.3 KB) - added by DrewAPicture 4 years ago.
Second pass.

Download all attachments as: .zip

Change History (9)

#1 @kpdesign
4 years ago

  • Owner set to kpdesign
  • Status changed from new to reviewing

#2 @DrewAPicture
4 years ago

  • Keywords needs-patch added; has-patch removed
  • Summary changed from Hooks Docs: wp-admin/includes/meta-boxes.php to Hook Docs (9): wp-admin/includes/meta-boxes.php

26092.patch is a great starting patch. Two things that jumped out at me are some needed spacing and wrapping on the page_attributes_dropdown_pages_args hook, and all versions should use the 3-digit x.x.x style.

4 years ago

Second pass.

#3 @DrewAPicture
4 years ago

  • Keywords has-patch docs-feedback added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.9

26092.2.patch is a second pass. Could use a once-over, especially on the actions that fire inside various meta boxes.

#4 @kpdesign
4 years ago

  • Keywords commit added; docs-feedback removed

26092.2.patch looks good. Recommend commit.

#5 @DrewAPicture
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26918:

Inline documentation for hooks in wp-admin/includes/meta-boxes.php.

Props SpencerFinnell for the initial patch.
Fixes #26092.

#6 @DrewAPicture
4 years ago

  • Focuses docs added

#7 @DrewAPicture
4 years ago

  • Component changed from Inline Docs to Editor
Note: See TracTickets for help on using tickets.