WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

Last modified 4 months ago

#26093 closed defect (bug) (fixed)

Twenty Fourteen: New PHP Coding Standards Brace Requirement

Reported by: rickalee Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Since 3.8 is new code I thought it would be appropriate to get in new brace requirement in trunk along with further feedback on how spacing after braces should be handled.

Attachments (3)

26093.patch (23.7 KB) - added by rickalee 5 months ago.
26093.2.diff (22.6 KB) - added by lancewillett 5 months ago.
Found a few more :)
26093.3.patch (2.6 KB) - added by NikV 5 months ago.
I might be able to add a few more.

Download all attachments as: .zip

Change History (10)

rickalee5 months ago

comment:1 follow-up: nacin5 months ago

This was contributed during the WordCamp Orlando contributor day. Looks good!

Side note for lancewillett: Instead of get_the_tag_list(), it looks like the theme can just use the_tags(). This would eliminate the echo and the has_tag() conditional.

comment:2 in reply to: ↑ 1 lancewillett5 months ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 3.8

Replying to nacin:

This was contributed during the WordCamp Orlando contributor day. Looks good!

Very cool! Thanks for contributing.

Side note for lancewillett: Instead of get_the_tag_list(), it looks like the theme can just use the_tags(). This would eliminate the echo and the has_tag() conditional.

Good call.

comment:3 lancewillett5 months ago

In 26258:

Twenty Fourteen: simplify tags output in content templates, props nacin. See #26093.

lancewillett5 months ago

Found a few more :)

comment:5 lancewillett5 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26260:

Twenty Fourteen: updates all PHP files to meet new brace style in WP coding standards. Props rickalee for initial patch, fixes #26093.

comment:6 lancewillett5 months ago

  • Keywords has-patch needs-refresh removed
  • Type changed from enhancement to defect (bug)
  • Version set to trunk

NikV5 months ago

I might be able to add a few more.

comment:7 nacin4 months ago

Hi NikV, attachments don't result in notifications, so no one saw [attchment:26093.3.patch]. Sorry about that!

Note: See TracTickets for help on using tickets.