WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#26093 closed defect (bug) (fixed)

Twenty Fourteen: New PHP Coding Standards Brace Requirement

Reported by: rickalee Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Since 3.8 is new code I thought it would be appropriate to get in new brace requirement in trunk along with further feedback on how spacing after braces should be handled.

Attachments (3)

26093.patch (23.7 KB) - added by rickalee 2 years ago.
26093.2.diff (22.6 KB) - added by lancewillett 2 years ago.
Found a few more :)
26093.3.patch (2.6 KB) - added by NikV 2 years ago.
I might be able to add a few more.

Download all attachments as: .zip

Change History (10)

@rickalee
2 years ago

#1 follow-up: @nacin
2 years ago

This was contributed during the WordCamp Orlando contributor day. Looks good!

Side note for lancewillett: Instead of get_the_tag_list(), it looks like the theme can just use the_tags(). This would eliminate the echo and the has_tag() conditional.

#2 in reply to: ↑ 1 @lancewillett
2 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 3.8

Replying to nacin:

This was contributed during the WordCamp Orlando contributor day. Looks good!

Very cool! Thanks for contributing.

Side note for lancewillett: Instead of get_the_tag_list(), it looks like the theme can just use the_tags(). This would eliminate the echo and the has_tag() conditional.

Good call.

#3 @lancewillett
2 years ago

In 26258:

Twenty Fourteen: simplify tags output in content templates, props nacin. See #26093.

@lancewillett
2 years ago

Found a few more :)

#5 @lancewillett
2 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26260:

Twenty Fourteen: updates all PHP files to meet new brace style in WP coding standards. Props rickalee for initial patch, fixes #26093.

#6 @lancewillett
2 years ago

  • Keywords has-patch needs-refresh removed
  • Type changed from enhancement to defect (bug)
  • Version set to trunk

@NikV
2 years ago

I might be able to add a few more.

#7 @nacin
2 years ago

Hi NikV, attachments don't result in notifications, so no one saw [attchment:26093.3.patch]. Sorry about that!

Note: See TracTickets for help on using tickets.