Opened 10 years ago
Closed 7 years ago
#26096 closed defect (bug) (invalid)
Caching issue in get_calendar() function
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.1 |
Component: | Posts, Post Types | Keywords: | has-patch needs-testing |
Focuses: | template, performance | Cc: |
Description
Now the result of get_calendar() execution is cached. Including checking of user agent:
if (strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== false || stripos($_SERVER['HTTP_USER_AGENT'], 'camino') !== false || stripos($_SERVER['HTTP_USER_AGENT'], 'safari') !== false)
I suggest to cache only db queries.
Attachments (1)
Change History (8)
#1
follow-up:
↓ 2
@
10 years ago
Yuck! The user agent is being detected here in order to insert line breaks into the title attributes, but only in browsers that support it. We should kill that code instead of altering the caching.
#2
in reply to:
↑ 1
@
10 years ago
Ok. But what about:
http://core.trac.wordpress.org/browser/tags/3.7.1/src/wp-includes/general-template.php#L1294
I think that cache will be cause of wrong "today" too.
#4
@
10 years ago
- Component changed from Template to Posts, Post Types
- Focuses template performance added
This ticket was mentioned in Slack in #core by peterwilsoncc. View the logs.
7 years ago
Note: See
TracTickets for help on using
tickets.
Caching only db queries.