Make WordPress Core

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#26098 closed defect (bug) (fixed)

authorURI defaults to /wp-admin/themes.php if not set in theme header

Reported by: morganestes's profile morganestes Owned by: dd32's profile dd32
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

If a theme doesn't include the Author URI field in the file header, it is still hyperlinked in the theme info modal window, but with an empty href.

Tested on trunk after THX38 integrated. I don't know what version this started with.

This only affects themes distributed outside the WordPress.org Themes Directory, as it checks for the proper file header.

My suggested fix is to check if the data.authorURI is present before creating the link. If not, display the author without the link.

Attachments (2)

2013-11-18_1021.png (34.5 KB) - added by morganestes 12 years ago.
Annotated screenshot showing the link with empty href
themes.diff (886 bytes) - added by morganestes 12 years ago.
Proposed changes

Download all attachments as: .zip

Change History (5)

@morganestes
12 years ago

Annotated screenshot showing the link with empty href

@morganestes
12 years ago

Proposed changes

#1 @SergeyBiryukov
12 years ago

  • Milestone changed from Awaiting Review to 3.8

#2 @dd32
11 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 26314:

Themes page: Don't display the Author as a link if the Author has no AuthorURI set. Props morganestes. Fixes #26098

#3 @lancewillett
11 years ago

  • Component changed from Themes to Appearance
Note: See TracTickets for help on using tickets.