New menu permissions code messes up plugins using globals

[ryanscheuermann]

In menu.php, the loops that recreate the menus based on permissions are called before the action "admin_menu" is called.

So any menus or submenus added by plugins aren't removed with the loops. Also, this causes problems when any plugins directly modify the global arrays $menu or $submenu using the original parent as a key.

Proposed fix: just moved the call to

do_action('admin_menu', '');

above the permission loops.

Also, submenus are not sorted by calling

ksort($menu); // make it all pretty

for my own sanity, please change to:

ksort($menu); // make it all pretty
foreach($submenu as $key => $menu_item) 
{
ksort($menu_item);
$submenu[$key] = $menu_item;
}

And I know that plugins are supposed to use the add_submenu_page, but that function contains no method of indicating the sort number for the menus. What's the point of using ksort if plugins can't add menu items where they want?

Thanks!

[ryanscheuermann]

changeset [3756] - fixed this issue (just doing some ticket cleanup)