WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#26137 closed defect (bug) (fixed)

colors-fresh.css is no longer an accurate filename

Reported by: melchoyce Owned by: nacin
Milestone: 3.8 Priority: low
Severity: normal Version: 3.8
Component: Administration Keywords:
Focuses: Cc:

Description

Since we no longer have the Fresh and Classic admin color schemes, colors-fresh.css is no longer an accurate filename.

Now that color schemes are handled differently (#25858), does it make sense to rename this file to colors.css or colors-base.css?

Change History (8)

#1 @SergeyBiryukov
7 years ago

  • Version set to trunk

#2 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 3.8

#4 @samuelsidler
7 years ago

  • Priority changed from normal to low

#5 @georgestephanis
7 years ago

Could changing colors-fresh to colors be a namespace conflict with some plugins/themes?

I'd prefer admin-colors or wp-colors personally.

#6 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26570:

Rename colors-fresh.css to colors.css. fixes #26137.

#7 @nacin
7 years ago

Deliberately leaving it as "fresh" internally, as there is no compelling reason to change it.

#8 @iammattthomas
7 years ago

I noticed that after r26570, the Gruntfile wasn't updated to reflect the change in path from /wp-admin/css/color-schemes/ to /wp-admin/css/colors/, so colors schemes weren't being generated properly. That fix was included in r26592.

Note: See TracTickets for help on using tickets.