Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#26140 closed defect (bug) (fixed)

Adjust thickbox positioning code for new toolbar height

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch commit
Focuses: Cc:


We have a code in several files that makes sure whenever thickbox is used, it's doesn't overlap with Toolbar.

Since the Toolbar height changed from 28px to 32px, we should adjust the code.

Attachments (2)

26140.patch (3.9 KB) - added by SergeyBiryukov 11 years ago.
26140.2.patch (5.1 KB) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (6)

#1 @johnbillion
11 years ago

Note that the height of the bar changes at narrower screen sizes. See George's comment here.

#2 @dd32
11 years ago

How about we adjust it to use the dynamic values as such:

parseInt( jQuery('#wpadminbar').css('height'), 10 );

#3 @SergeyBiryukov
11 years ago

26140.2.patch uses jQuery('#wpadminbar').css('height').

Also fixes the issue with thickbox positioning on Manage Themes screen (ticket:26078:3).

#4 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26323:

Fix thickbox positioning on Manage Themes screen. Adjust thickbox resizing code on various screens for new toolbar height.

see #26078. fixes #26140.

Note: See TracTickets for help on using tickets.