Make WordPress Core

Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#26145 closed defect (bug) (fixed)

Row actions are not keyboard accessible

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Accessibility Keywords: has-patch commit
Focuses: ui Cc:


Background: #21334

Tabbing to the items in the lists no longer triggers appearance of Quick Edit links.

Fixed for 3.7 in [25595], which depended on [25592].

Re-broken in [26072], which essentially reverted [25592].

Attachments (2)

26145.patch (1.3 KB) - added by SergeyBiryukov 23 months ago.
26145.2.patch (1.3 KB) - added by SergeyBiryukov 23 months ago.

Download all attachments as: .zip

Change History (9)

@SergeyBiryukov23 months ago

@SergeyBiryukov23 months ago

comment:1 @SergeyBiryukov23 months ago

  • Keywords commit added

26145.patch re-introduces [25592].

26145.2.patch also removes lines 132 and 133 in colors-fresh.css, which seem redundant.

comment:2 follow-up: @dd3223 months ago

How are you testing this?

From what I can see, under both a clean 3.7 and trunk, tabbing to the fields does not work on the plugins page, or the Posts page.
Under 3.7 the Plugins links are forced to be displayed (but Posts are not) and this patch matches that style.. but it doesn't appear to actually make it accessible the same way that [25595] was trying to do

comment:3 in reply to: ↑ 2 @SergeyBiryukov23 months ago

Replying to dd32:

How are you testing this?

  1. Go to the Posts screen.
  2. Click the checkbox on the left of any post and press Tab.

In 3.7, this will reveal the action links for that post. In trunk, nothing happens.

The JS introduced in [25595] still adds the .visible class, but the proper styling is missing.

.row-actions-visible class no longer exists in core since [25592], but the CSS part of that changeset was reverted during the merge in [26072].

Last edited 23 months ago by SergeyBiryukov (previous) (diff)

comment:4 @dd3223 months ago

Ahah, got it now.
With the patch the Posts screen now works as explained (Row actions show when tab from the checkbox, but hidden otherwise), however the plugins page always shows the actions, can we make it work like the Posts page too?

comment:5 @SergeyBiryukov23 months ago

Plugins isn't the only screen that always shows the actions (since [11367], moved to list tables in [15924]), Themes in network admin does too (since [16113]).

We could probably change that, but it sounds like a separate UI/UX change to me that should be done in another ticket.

comment:6 @SergeyBiryukov23 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26324:

Fix keyboard accessibility for row actions in list tables. Restore the CSS part of [25592], accidentally reverted in [26072].

fixes #26145.

comment:7 @SergeyBiryukov23 months ago

#26166 was marked as a duplicate.

Note: See TracTickets for help on using tickets.