Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#26178 closed defect (bug) (fixed)

Double close button in thickbox

Reported by: matczar's profile matczar Owned by: iammattthomas's profile iammattthomas
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: needs-patch
Focuses: ui Cc:

Description

There is unnecessary background image in .tb-close-icon class (wp-includes/js/thickbox/thickbox.css). This causes thickbox window has double close button.

Attachments (2)

2013-11-23_12-37-57.png (5.1 KB) - added by matczar 11 years ago.
tb-icon-close.png (15.7 KB) - added by zerodegreeburn 11 years ago.

Download all attachments as: .zip

Change History (8)

#1 @ocean90
11 years ago

  • Keywords needs-patch ui-focus added
  • Milestone changed from Awaiting Review to 3.8
  • Severity changed from trivial to normal

Happens if SCRIPT_DEBUG is false.

thickbox.css is loaded after the styles via load-styles.php.

#2 @kstover
11 years ago

Just wanted to add that this error isn't reproducible in OSX with Chrome 31.0.1650.57 or FireFox 25.0.1.

#3 @zerodegreeburn
11 years ago

I reproduced this error in Windows 7 and 8, in Chrome, Firefox, IE and Opera (all latest versions).

In my opinion the original thickbox.css .tb-close-icon looks better. The new .tb-close-icon:before's icon is 12px tall and trying to fit into a 27px height - so it can't be properly centered (see screenshot).

Disabling .tb-close-icon's background fixes the issue, but the new psuedo element's alignment is off.

#4 @iammattthomas
11 years ago

  • Owner set to iammattthomas
  • Resolution set to fixed
  • Status changed from new to closed

In 26395:

Move thickbox styles from wp-admin.css to thickbox.css. Remove old png close icons. Fixes #26178.

#5 @iammattthomas
11 years ago

I've moved all the MP6-era thickbox styles out of wp-admin and into thickbox.css, while removing the old close button styles. I updated the font stack to include Open Sans and adjusted the margin on the close button so it's better-aligned than it was before.

#6 @iammattthomas
11 years ago

In 26396:

Remove the new thickbox styles from wp-admin.css. See #26178

Note: See TracTickets for help on using tickets.