WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#26181 closed defect (bug) (fixed)

RTL: Login screen has 92% for padding-top

Reported by: ocean90 Owned by: nacin
Priority: normal Milestone: 3.8
Component: RTL Version:
Severity: minor Keywords: needs-patch
Cc: Focuses: ui

Description

See ​http://cl.ly/SdZQ.

Attachments (1)

26181.patch​ (310 bytes ) - added by ocean90 13 years ago.

Download all attachments as: .zip

Change History (9)

@ocean90
13 years ago

#1 follow-up: @ocean90
13 years ago

  • Cc yoavf added

Adding /* @noflip */ seems to fix the issue for now, see 26181.patch​. I have no idea why it's swapped. Maybe yoavf has something.

For the record: I can't reproduce the issue with ​http://cssjanus.commoner.com/.

#2 in reply to: ↑ 1 @yoavf
13 years ago

Thanks for the ping, Dominik. I'll look into it - maybe a bug in the nodejs module we're using.

#3 @matt
13 years ago

  • Severity normal → minor

#4 @SergeyBiryukov
13 years ago

  • Component Administration → RTL

#5 @ocean90
13 years ago

The same happens for .theme. The module transforms margin: 0 5% 4% 0; into margin: 0 0 96% 5%.

#6 @dd32
13 years ago

Bug filed upstream: ​https://github.com/trevorparscal/cssjanus/pull/4

The cause is that the Background flipping regex is too greedy causing it to incorrectly flip the Margins.

#7 @nacin
13 years ago

I have a fork at ​https://github.com/nacin/cssjanus that incorporates fixes by both dd32 and yoavf. Going to "pin" some things for now.

#8 @nacin
13 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In 26610:

Temporarily switch to a pinned version of grunt-cssjanus. This in turn temporarily pins cssjanus to a patched fork.

fixes #26181, #26182.

Note: See TracTickets for help on using tickets.