WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#26186 closed defect (bug) (fixed)

Hook Docs (2): wp-admin/includes/misc.php

Reported by: JoshuaAbenazer Owned by: DrewAPicture
Priority: normal Milestone: 3.9
Component: Administration Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: docs

Description

Attached patch has docs for the documentation_ignore_functions and set-screen-option filters in wp-admin/includes/misc.php

Attachments (2)

wp-admin_includes_misc-php.diff​ (1.4 KB ) - added by JoshuaAbenazer 13 years ago.
26186.diff​ (977 bytes ) - added by DrewAPicture 13 years ago.

Download all attachments as: .zip

Change History (9)

@JoshuaAbenazer
13 years ago

#1 @DrewAPicture
13 years ago

  • Owner set to DrewAPicture
  • Status new → reviewing
  • Summary Hook Docs: wp-admin/includes/misc.php → Hook Docs (2): wp-admin/includes/misc.php

At a glance, wp-admin_includes_misc-php.diff​ looks pretty good. Lucked out, since 2 of the 4 hooks in this file were already documented ;)

#2 @jeremyfelt
13 years ago

  • Component Inline Docs → Administration
  • Focuses docs added

#3 @DrewAPicture
13 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 3.9

wp-admin_includes_misc-php.diff​ should do it. Thanks for the patch!

#4 @DrewAPicture
13 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 27375:

Inline documentation for hooks in wp-admin/includes/misc.php.

Props JoshuaAbenazer.
Fixes #26186

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. ​View the logs.
13 years ago

@DrewAPicture
13 years ago

#6 @DrewAPicture
13 years ago

  • Resolution fixed
  • Status closed → reopened

@nacin pointed out that set-screen-option really is a general-purpose screen option filter and not actually specific to [items]_per_page options.

26186.diff​ generalizes the hook doc.

#7 @DrewAPicture
13 years ago

  • Resolution → fixed
  • Status reopened → closed

In 27379:

Generalize the hook documentation for the set-screen-option filter.

The filter covers more than [items]_per_page screen options.

Fixes #26186.

Note: See TracTickets for help on using tickets.