WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#26186 closed defect (bug) (fixed)

Hook Docs (2): wp-admin/includes/misc.php

Reported by: JoshuaAbenazer Owned by: DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit
Focuses: docs Cc:
PR Number:

Description

Attached patch has docs for the documentation_ignore_functions and set-screen-option filters in wp-admin/includes/misc.php

Attachments (2)

wp-admin_includes_misc-php.diff (1.4 KB) - added by JoshuaAbenazer 6 years ago.
26186.diff (977 bytes) - added by DrewAPicture 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @DrewAPicture
6 years ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing
  • Summary changed from Hook Docs: wp-admin/includes/misc.php to Hook Docs (2): wp-admin/includes/misc.php

At a glance, wp-admin_includes_misc-php.diff looks pretty good. Lucked out, since 2 of the 4 hooks in this file were already documented ;)

#2 @jeremyfelt
6 years ago

  • Component changed from Inline Docs to Administration
  • Focuses docs added

#3 @DrewAPicture
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.9

wp-admin_includes_misc-php.diff should do it. Thanks for the patch!

#4 @DrewAPicture
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27375:

Inline documentation for hooks in wp-admin/includes/misc.php.

Props JoshuaAbenazer.
Fixes #26186

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


6 years ago

@DrewAPicture
6 years ago

#6 @DrewAPicture
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@nacin pointed out that set-screen-option really is a general-purpose screen option filter and not actually specific to [items]_per_page options.

26186.diff generalizes the hook doc.

#7 @DrewAPicture
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 27379:

Generalize the hook documentation for the set-screen-option filter.

The filter covers more than [items]_per_page screen options.

Fixes #26186.

Note: See TracTickets for help on using tickets.