Context Navigation

← Previous Ticket
Next Ticket →

#26187 closed defect (bug) (fixed)

Translation function used instead of just escaping in wp-admin/includes/nav-menu.php

Reported by:	yoavf	Owned by:	ocean90
Priority:	normal	Milestone:	3.8
Component:	Menus	Version:	3.6
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description

Line 850, esc_attr_e used instead of just esc_attr - no translation needed here. Since r23441.

Attachments (2)

wrong-escpaing-function.diff (916 bytes ) - added by yoavf 13 years ago.
26187.diff (921 bytes ) - added by mattheu 13 years ago.: Update patch - esc_attr does not echo

Download all attachments as: .zip

Change History (8)

@yoavf
13 years ago

Attachment wrong-escpaing-function.diff added

@mattheu
13 years ago

Attachment 26187.diff added

Update patch - esc_attr does not echo

#1 @mattheu
13 years ago

Need to echo the escaped string when using esc_attr

#2 @ocean90
13 years ago

Component General → Menus
Keywords commit added
Milestone → 3.8
Version 3.7.1 → 3.6

#3 @ocean90
13 years ago

Owner set to ocean90
Resolution → fixed
Status new → closed

In 26347:

Don't use esc_attr_e() function for a non-translatable context.

props yoavf, mattheu.
fixes #26187.

#4 @markoheijnen
13 years ago

There is another line in there: esc_attr_e( __( 'Add to Menu' ) ) what can be esc_attr_e( 'Add to Menu' ) right?

Last edited 13 years ago by SergeyBiryukov (previous) (diff)

#5 @ocean90
13 years ago

markoheijnen, patch? :-)

#6 @SergeyBiryukov
13 years ago

In 26349:

Remove redundant translation function calls.

props markoheijnen.
see #26187.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#26187 closed defect (bug) (fixed)

Translation function used instead of just escaping in wp-admin/includes/nav-menu.php

Description

Attachments (2)

Change History (8)

@yoavf 13 years ago

@mattheu 13 years ago

#1 @mattheu 13 years ago

#2 @ocean90 13 years ago

#3 @ocean90 13 years ago

#4 @markoheijnen 13 years ago

#5 @ocean90 13 years ago

#6 @SergeyBiryukov 13 years ago