WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#26203 closed defect (bug) (fixed)

Hook Docs (3): wp-admin/includes/class-wp-users-list-table.php

Reported by: leewillis77 Owned by: DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch commit
Focuses: docs Cc:

Description

Patch in development

Attachments (3)

26203.diff (5.3 KB) - added by leewillis77 7 years ago.
Hook docs patch
26203.2.diff (1.8 KB) - added by leewillis77 7 years ago.
Revised patch, hook docs only
26203.3.diff (1.9 KB) - added by kpdesign 7 years ago.
Alignment and language fixes

Download all attachments as: .zip

Change History (13)

@leewillis77
7 years ago

Hook docs patch

#1 @leewillis77
7 years ago

  • Keywords has-patch added

#2 follow-up: @DrewAPicture
7 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to DrewAPicture
  • Status changed from new to reviewing
  • Summary changed from Hook docs: wp-admin/includes/class-wp-users-list-table.php to Hook Docs (3): wp-admin/includes/class-wp-users-list-table.php

Looks like there are a whole bunch of functional docs mixed in to this patch. And that's great, because you can absolutely break those out into their own patch and submit a new functional docs ticket :)

Other than that, we'll review the hook docs for the 3 hooks in this file and post back.

@leewillis77
7 years ago

Revised patch, hook docs only

#3 in reply to: ↑ 2 @SergeyBiryukov
7 years ago

Replying to DrewAPicture:

Looks like there are a whole bunch of functional docs mixed in to this patch. And that's great, because you can absolutely break those out into their own patch and submit a new functional docs ticket :)

Follow-up: #26564

#4 @kpdesign
7 years ago

  • Keywords has-patch added; needs-patch removed

#5 @jeremyfelt
7 years ago

  • Component changed from Inline Docs to Users
  • Focuses docs added

#6 @DrewAPicture
7 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.9

#7 @DrewAPicture
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27342:

Inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php.

Props leewillis77.
Fixes #26203.

@kpdesign
7 years ago

Alignment and language fixes

#8 @kpdesign
7 years ago

26203.3.diff contains fixes for an alignment issue and language consistency.

#9 @DrewAPicture
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#10 @DrewAPicture
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 27355:

Tweak inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php.

Props kpdesign.
Fixes #26203.

Note: See TracTickets for help on using tickets.