WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 2 months ago

#26209 closed defect (bug) (fixed)

Hook Docs (10): wp-admin/includes/class-wp-terms-list-table.php

Reported by: Ajay Owned by: DrewAPicture
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Taxonomy Keywords: has-patch commit
Focuses: docs Cc:

Description

Attached patch has docs for edit_tags_per_page, tagsperpage, edit_categories_per_page, term_name, tag_row_actions, {$taxonomy}_row_actions, editable_slug, manage_{$this->screen->taxonomy}_custom_column filters and quick_edit_custom_box action

Attachments (4)

class-wp-terms-list-table.patch (4.4 KB) - added by Ajay 5 months ago.
26209.diff (4.4 KB) - added by Ajay 4 months ago.
26209.1.diff (4.6 KB) - added by kpdesign 3 months ago.
Third pass
26209.2.diff (4.8 KB) - added by DrewAPicture 3 months ago.
Final pass.

Download all attachments as: .zip

Change History (10)

comment:1 DrewAPicture4 months ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to kpdesign
  • Status changed from new to reviewing
  • Summary changed from Hooks Docs: wp-admin/includes/class-wp-terms-list-table.php to Hook Docs (10): wp-admin/includes/class-wp-terms-list-table.php

Hi, thanks for the patch.

Looking at class-wp-terms-list-table.patch, seems like spacing was done with tabs instead of spaces. Also, some parameter descriptions are missing. Could use iteration and tidying up.

Ajay4 months ago

comment:2 Ajay4 months ago

  • Keywords has-patch added; needs-patch removed

I've attached an updated diff file 26209.diff which changes the tabs to spaces and also fixed a missing parameter. Please let me know if this is fine.

comment:3 jeremyfelt3 months ago

  • Component changed from Inline Docs to Taxonomy
  • Focuses docs added

kpdesign3 months ago

Third pass

comment:4 kpdesign3 months ago

  • Owner changed from kpdesign to DrewAPicture

26209.1.diff contains improvements to descriptions, documents duplicate hooks, and some formatting changes.

This needs a secondary review and recommendation.

DrewAPicture3 months ago

Final pass.

comment:5 DrewAPicture3 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.9
  • Status changed from reviewing to accepted

Double-checked all of the @since versions and 26209.2.diff fixes one. Also adds some spacing and s/tag/term in a couple of places. Ready to go in.

comment:6 DrewAPicture2 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 27089:

Inline documentation for hooks in wp-admin/includes/class-wp-terms-list-table.php.

Props Ajay, kpdesign.
Fixes #26209.

Note: See TracTickets for help on using tickets.