Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#26217 closed defect (bug) (fixed)

Hook Docs (2): wp-includes/class-wp-theme.php

Reported by: richard2222's profile richard2222 Owned by: kpdesign's profile kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: docs Cc:

Description (last modified by kpdesign)

Attached patch for filters:

wp_cache_themes_persistently
allowed_themes

Attachments (3)

26217.patch (1.0 KB) - added by richard2222 10 years ago.
26217.2.patch (1.0 KB) - added by kpdesign 10 years ago.
Second pass
26217.3.patch (1.0 KB) - added by DrewAPicture 10 years ago.
Final pass

Download all attachments as: .zip

Change History (12)

@richard2222
10 years ago

#1 @kpdesign
10 years ago

  • Owner set to kpdesign
  • Status changed from new to reviewing

#2 @kpdesign
10 years ago

  • Description modified (diff)
  • Version trunk deleted

#3 @DrewAPicture
10 years ago

  • Keywords needs-patch added; has-patch removed
  • Summary changed from Hook Docs: wp-includes/class-wp-theme.php to Hook Docs (2): wp-includes/class-wp-theme.php

Looking at 26217.patch, looks like the variable was missed on the allowed_themes hook. Could use a review and recommendation.

@kpdesign
10 years ago

Second pass

#4 @kpdesign
10 years ago

26217.2.patch adds missing variable in allowed themes, fixes @since value, and minor alignment fixes.

Ready for a second review and a recommendation.

#5 @kpdesign
10 years ago

  • Keywords has-patch added; needs-patch removed

@DrewAPicture
10 years ago

Final pass

#6 @DrewAPicture
10 years ago

  • Milestone changed from Awaiting Review to 3.9

#7 @DrewAPicture
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26891:

Inline documentation for hooks in wp-includes/class-wp-theme.php.

Props richard2222, kpdesign.
Fixes #26217.

#8 @DrewAPicture
10 years ago

  • Focuses docs added

#9 @DrewAPicture
10 years ago

  • Component changed from Inline Docs to Themes
Note: See TracTickets for help on using tickets.