WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#26227 closed defect (bug) (fixed)

Dashicons: Include the easy-access classes for plugins

Reported by: dd32 Owned by: nacin
Priority: normal Milestone: 3.8
Component: Graphic Design Version: 3.8
Severity: normal Keywords: has-patch 2nd-opinion
Cc: Focuses:

Description

Currently the version of Dashicons in core doesn't include the easy-access/easy-use CSS classes such as .dashicons and .dashicon-wordpress, which forces themes to use the glyphs directly by specifying the fonts and content:'\f155';.

Instead, we should include the full set of icon classes as visible within the Dashicons CSS: ​https://github.com/melchoyce/dashicons/blob/master/css/dashicons.css

Attachments (2)

26227.diff​ (10.1 KB ) - added by dd32 13 years ago.
26227.2.diff​ (54.0 KB ) - added by melchoyce 13 years ago.

Download all attachments as: .zip

Change History (8)

#1 @melchoyce
13 years ago

  • Cc melissachoyce@… added

I kind of guessed on some of the class names — I'd appreciate a second look to make sure everything I've named them makes sense.

@dd32
13 years ago

#2 @dd32
13 years ago

26227.diff​ is the extra rules.

The class names are visible within there, and also on the demo site here: ​http://melchoyce.github.io/dashicons/

I personally haven't seen any I disagree with, but it'd be helpful if others could comb through it as well.

#3 @dd32
13 years ago

  • Keywords has-patch 2nd-opinion added

#4 @nacin
13 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In 26547:

Add dashicons CSS classes for easy access by plugins and themes.

props dd32.
fixes #26227.

@melchoyce
13 years ago

#5 @melchoyce
13 years ago

  • Resolution fixed
  • Status closed → reopened

In 26227.2.diff​, I updated the following icon class names:

Old New
dashicons-admin-sitedashicons-admin-network
dashicons-sitedashicons-admin-site
dashicons-gaugedashicons-admin-dashboard
dashicons-admin-dashboarddashicons-admin-home
dashicons-camera2dashicons-camera
dashicons-imgedit-undodashicons-undo
dashicons-imgedit-redodashicons-redo
dashicons-xitdashicons-dismiss
dashicons-arrow-updashicons-upload
dashicons-arrow-downdashicons-download
dashicons-networkdashicons-networking
dashicons-jobs-developersdashicons-hammer
dashicons-jobs-designersdashicons-art
dashicons-jobs-migrationdashicons-migrate
dashicons-jobs-performancedashicons-performance

Also:

  • imgedit --> image, write out full name (rleft --> rotate-left)
  • graphs to --> chart-bar, chart-line, chart-area, chart-pie
  • change everything with 1/2/3 to alt, alt-2
  • change all arr to arrow
  • remove twitter-alt b/c it's not correct branding

I also updated the data-uri for the font based on the latest version of dashicons.

Last edited 13 years ago by DrewAPicture (previous) (diff)

#6 @nacin
13 years ago

  • Resolution → fixed
  • Status reopened → closed

In 26752:

Updates to Dashicons classes.

props melchoyce.
fixes #26227.

Note: See TracTickets for help on using tickets.