WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#26238 closed defect (bug) (fixed)

WP Post content editor - border between editor and word count appears too thick.

Reported by: mattheu Owned by: iammattthomas
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Editor Keywords: has-patch
Focuses: ui Cc:

Description

On the edit screen in the admin, the border at the between the bottom of the post content editor and the bar that displays the word count appears to be 2px when I think it should probably be 1px. See screenshot.

https://dl.dropboxusercontent.com/s/pavi9lwfr66amua/2013-11-25%20at%2016.29.png

This is not actually caused by a border - but because the wp-editor-container has the styles position: relative; top: -1px; - nudging this element up by 1px and creating a gap allowing the body background color to show through. This can be seen by setting the body background color to red. See screenshot 2

https://dl.dropboxusercontent.com/s/gz2npt2tv18wgsj/2013-11-25%20at%2016.34.png

This was originally done to correctly align the tabs to switch editors (visual/text) however I think it would be better to align the tabs to the editor container - rather than the other way round.

Attaching a patch to fix this.

Attachments (2)

26238.diff (482 bytes) - added by mattheu 7 years ago.
26238-2.diff (987 bytes) - added by mattheu 7 years ago.
account for mobile & press this

Download all attachments as: .zip

Change History (7)

@mattheu
7 years ago

#1 @mattheu
7 years ago

Checked Chrome, FF and IE8+ to make sure this wasn't done originally to fix a browser issue.

@mattheu
7 years ago

account for mobile & press this

#2 @mattheu
7 years ago

Updated patch to make sure the tabs look nice on small screens & in the "press this" window

#3 @SergeyBiryukov
7 years ago

  • Component changed from General to Editor
  • Keywords ui-focus added

#4 @iammattthomas
7 years ago

  • Owner set to iammattthomas
  • Resolution set to fixed
  • Status changed from new to closed

In 26411:

Better alignment of Visual and Text tabs with editor, better alignment of word count container with editor, eliminate gap between tabs and editor on Press This. Fixes #26238, props mattheu.

#5 @iammattthomas
7 years ago

  • Milestone changed from Awaiting Review to 3.8
  • Version set to trunk
Note: See TracTickets for help on using tickets.